PHP 7.4 and 8.0 pipelines seem affected by this obscure Valgrind bug.

php/php-src#10221

Author: 1ma

.github/workflows/ci.yml

@@ -14,17 +14,21 @@ jobs:
       - uses: actions/checkout@v3
         with:
           submodules: recursive
-      - uses: shivammathur/setup-php@verbose
+      - uses: shivammathur/setup-php@v2
         env:
           debug: true
-          update: true
         with:
           php-version: ${{ matrix.php-version }}
           ini-values: opcache.enable=1, opcache.enable_cli=1, opcache.protect_memory=1
       - name: Build secp256k1 and PHP extension
         run: |
           make secp256k1 ext
-      - name: Test PHP extension
+      - name: Test PHP extension without Valgrind
+        if: ${{ matrix.php-version == '7.4' || matrix.php-version == '8.0' }}
         run: |
-          sudo apt-get install valgrind
           make check
+      - name: Test PHP extension with Valgrind
+        if: ${{ matrix.php-version == '8.1' || matrix.php-version == '8.2' }}
+        run: |
+          sudo apt-get install valgrind
+          make check-valgrind

Makefile

@@ -1,4 +1,4 @@
-.PHONY: ext secp256k1 check install clean
+.PHONY: ext secp256k1 check check-valgrind install clean
 
 ext:
 	cd ext && \
@@ -22,6 +22,9 @@ secp256k1:
 	make -C secp256k1 install
 
 check:
+	make -C ext test TESTS="-q --show-diff --show-mem"
+
+check-valgrind:
 	make -C ext test TESTS="-q -m --show-diff --show-mem"
 
 install:

README.md

@@ -137,12 +137,6 @@ for a valid private key, but in practice this should never happen.
 $ make check
 ```
 
-You will need Valgrind on your system to run this command. On Ubuntu that'd be:
-
-```shell
-$ sudo apt install valgrind
-```
-
 ### Does `secp256k1_nostr` follow [semantic versioning](https://semver.org/)?
 
 Yes, but the API may still evolve before the 1.0 release.