Skip to content

Commit 396e287

Browse files
vittyvkgregkh
authored andcommitted
Drivers: hv: get rid of timeout in vmbus_open()
vmbus_teardown_gpadl() can result in infinite wait when it is called on 5 second timeout in vmbus_open(). The issue is caused by the fact that gpadl teardown operation won't ever succeed for an opened channel and the timeout isn't always enough. As a guest, we can always trust the host to respond to our request (and there is nothing we can do if it doesn't). Signed-off-by: Vitaly Kuznetsov <[email protected]> Signed-off-by: K. Y. Srinivasan <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 7cc80c9 commit 396e287

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

drivers/hv/channel.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ int vmbus_open(struct vmbus_channel *newchannel, u32 send_ringbuffer_size,
7373
void *in, *out;
7474
unsigned long flags;
7575
int ret, err = 0;
76-
unsigned long t;
7776
struct page *page;
7877

7978
spin_lock_irqsave(&newchannel->lock, flags);
@@ -183,11 +182,7 @@ int vmbus_open(struct vmbus_channel *newchannel, u32 send_ringbuffer_size,
183182
goto error1;
184183
}
185184

186-
t = wait_for_completion_timeout(&open_info->waitevent, 5*HZ);
187-
if (t == 0) {
188-
err = -ETIMEDOUT;
189-
goto error1;
190-
}
185+
wait_for_completion(&open_info->waitevent);
191186

192187
spin_lock_irqsave(&vmbus_connection.channelmsg_lock, flags);
193188
list_del(&open_info->msglistentry);

0 commit comments

Comments
 (0)