Skip to content

Commit 69fc8fa

Browse files
jbrockmendelSeeminSyed
authored andcommitted
CLN: avoid .setitem in tests (pandas-dev#32852)
1 parent 77e34ad commit 69fc8fa

File tree

2 files changed

+8
-13
lines changed

2 files changed

+8
-13
lines changed

pandas/tests/dtypes/test_inference.py

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
import pytest
1717
import pytz
1818

19-
from pandas._libs import iNaT, lib, missing as libmissing
19+
from pandas._libs import lib, missing as libmissing
2020
import pandas.util._test_decorators as td
2121

2222
from pandas.core.dtypes import inference
@@ -50,7 +50,6 @@
5050
Timedelta,
5151
TimedeltaIndex,
5252
Timestamp,
53-
isna,
5453
)
5554
import pandas._testing as tm
5655
from pandas.core.arrays import IntegerArray
@@ -1480,14 +1479,12 @@ def test_nan_to_nat_conversions():
14801479
dict({"A": np.asarray(range(10), dtype="float64"), "B": Timestamp("20010101")})
14811480
)
14821481
df.iloc[3:6, :] = np.nan
1483-
result = df.loc[4, "B"].value
1484-
assert result == iNaT
1482+
result = df.loc[4, "B"]
1483+
assert result is pd.NaT
14851484

14861485
s = df["B"].copy()
1487-
s._data = s._data.setitem(indexer=tuple([slice(8, 9)]), value=np.nan)
1488-
assert isna(s[8])
1489-
1490-
assert s[8].value == np.datetime64("NaT").astype(np.int64)
1486+
s[8:9] = np.nan
1487+
assert s[8] is pd.NaT
14911488

14921489

14931490
@td.skip_if_no_scipy

pandas/tests/extension/base/setitem.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import operator
2-
31
import numpy as np
42
import pytest
53

@@ -60,7 +58,7 @@ def test_setitem_sequence_broadcasts(self, data, box_in_series):
6058
def test_setitem_scalar(self, data, setter):
6159
arr = pd.Series(data)
6260
setter = getattr(arr, setter)
63-
operator.setitem(setter, 0, data[1])
61+
setter[0] = data[1]
6462
assert arr[0] == data[1]
6563

6664
def test_setitem_loc_scalar_mixed(self, data):
@@ -196,7 +194,7 @@ def test_setitem_mask_aligned(self, data, as_callable, setter):
196194
# Series.__setitem__
197195
target = ser
198196

199-
operator.setitem(target, mask2, data[5:7])
197+
target[mask2] = data[5:7]
200198

201199
ser[mask2] = data[5:7]
202200
assert ser[0] == data[5]
@@ -213,7 +211,7 @@ def test_setitem_mask_broadcast(self, data, setter):
213211
else: # __setitem__
214212
target = ser
215213

216-
operator.setitem(target, mask, data[10])
214+
target[mask] = data[10]
217215
assert ser[0] == data[10]
218216
assert ser[1] == data[10]
219217

0 commit comments

Comments
 (0)