Bump clippy::version for some lints

Centri3 · Centri3 · commit 86ce182b5a4c · 2023-08-01T01:42:07.000-05:00
Also moves `tuple_array_conversions` to `pedantic`, because rust-lang#11171 didn't contain it fsr
diff --git a/clippy_lints/src/error_impl_error.rs b/clippy_lints/src/error_impl_error.rs
@@ -28,7 +28,7 @@ declare_clippy_lint! {
     ///
     /// impl std::error::Error for Error { ... }
     /// ```
-    #[clippy::version = "1.72.0"]
+    #[clippy::version = "1.73.0"]
     pub ERROR_IMPL_ERROR,
     restriction,
     "exported types named `Error` that implement `Error`"
diff --git a/clippy_lints/src/excessive_nesting.rs b/clippy_lints/src/excessive_nesting.rs
@@ -56,7 +56,7 @@ declare_clippy_lint! {
     /// // lib.rs
     /// pub mod a;
     /// ```
-    #[clippy::version = "1.70.0"]
+    #[clippy::version = "1.72.0"]
     pub EXCESSIVE_NESTING,
     complexity,
     "checks for blocks nested beyond a certain threshold"
diff --git a/clippy_lints/src/four_forward_slashes.rs b/clippy_lints/src/four_forward_slashes.rs
@@ -28,7 +28,7 @@ declare_clippy_lint! {
     ///     // ...
     /// }
     /// ```
-    #[clippy::version = "1.72.0"]
+    #[clippy::version = "1.73.0"]
     pub FOUR_FORWARD_SLASHES,
     suspicious,
     "comments with 4 forward slashes (`////`) likely intended to be doc comments (`///`)"
diff --git a/clippy_lints/src/methods/mod.rs b/clippy_lints/src/methods/mod.rs
@@ -3365,6 +3365,7 @@ declare_clippy_lint! {
 }
 
 declare_clippy_lint! {
+    /// ### What it does
     /// Looks for calls to [`Stdin::read_line`] to read a line from the standard input
     /// into a string, then later attempting to parse this string into a type without first trimming it, which will
     /// always fail because the string has a trailing newline in it.
@@ -3415,7 +3416,7 @@ declare_clippy_lint! {
     /// # let c = 'c';
     /// matches!(c, '\\' | '.' | '+' | '*' | '(' | ')' | '|' | '[' | ']' | '{' | '}' | '^' | '$' | '#' | '&' | '-' | '~');
     /// ```
-    #[clippy::version = "1.72.0"]
+    #[clippy::version = "1.73.0"]
     pub STRING_LIT_CHARS_ANY,
     restriction,
     "checks for `<string_lit>.chars().any(|i| i == c)`"
@@ -3450,7 +3451,7 @@ declare_clippy_lint! {
     ///     })
     /// }
     /// ```
-    #[clippy::version = "1.72.0"]
+    #[clippy::version = "1.73.0"]
     pub FORMAT_COLLECT,
     perf,
     "`format!`ing every element in a collection, then collecting the strings into a new `String`"
@@ -3471,7 +3472,7 @@ declare_clippy_lint! {
     /// let y = v.iter().collect::<Vec<_>>();
     /// assert_eq!(x, y);
     /// ```
-    #[clippy::version = "1.72.0"]
+    #[clippy::version = "1.73.0"]
     pub ITER_SKIP_ZERO,
     correctness,
     "disallows `.skip(0)`"
diff --git a/clippy_lints/src/needless_pass_by_ref_mut.rs b/clippy_lints/src/needless_pass_by_ref_mut.rs
@@ -214,7 +214,7 @@ impl<'tcx> LateLintPass<'tcx> for NeedlessPassByRefMut<'tcx> {
                                 diag.warn("changing this function will impact semver compatibility");
                             }
                             if *is_cfged {
-                                diag.note("this is cfg-gated and may require further changes");
+                                diag.note("this is `cfg`-gated and may require further changes");
                             }
                         },
                     );
diff --git a/clippy_lints/src/tuple_array_conversions.rs b/clippy_lints/src/tuple_array_conversions.rs
@@ -37,7 +37,7 @@ declare_clippy_lint! {
     /// ```
     #[clippy::version = "1.72.0"]
     pub TUPLE_ARRAY_CONVERSIONS,
-    nursery,
+    pedantic,
     "checks for tuple<=>array conversions that are not done with `.into()`"
 }
 impl_lint_pass!(TupleArrayConversions => [TUPLE_ARRAY_CONVERSIONS]);
diff --git a/tests/ui/needless_pass_by_ref_mut.rs b/tests/ui/needless_pass_by_ref_mut.rs
@@ -4,7 +4,7 @@
 use std::ptr::NonNull;
 
 fn foo(s: &mut Vec<u32>, b: &u32, x: &mut u32) {
-    //~^ ERROR: this argument is a mutable reference, but not used mutably
+    //~^ ERROR: this argument is a mutable reference, but never used mutably
     *x += *b + s.len() as u32;
 }
 
@@ -29,7 +29,7 @@ fn foo5(s: &mut Vec<u32>) {
 }
 
 fn foo6(s: &mut Vec<u32>) {
-    //~^ ERROR: this argument is a mutable reference, but not used mutably
+    //~^ ERROR: this argument is a mutable reference, but never used mutably
     non_mut_ref(s);
 }
 
@@ -42,12 +42,12 @@ impl Bar {
     fn bar(&mut self) {}
 
     fn mushroom(&self, vec: &mut Vec<i32>) -> usize {
-        //~^ ERROR: this argument is a mutable reference, but not used mutably
+        //~^ ERROR: this argument is a mutable reference, but never used mutably
         vec.len()
     }
 
     fn badger(&mut self, vec: &mut Vec<i32>) -> usize {
-        //~^ ERROR: this argument is a mutable reference, but not used mutably
+        //~^ ERROR: this argument is a mutable reference, but never used mutably
         vec.len()
     }
 }
@@ -124,35 +124,35 @@ async fn f7(x: &mut i32, y: i32, z: &mut i32, a: i32) {
 }
 
 async fn a1(x: &mut i32) {
-    //~^ ERROR: this argument is a mutable reference, but not used mutably
+    //~^ ERROR: this argument is a mutable reference, but never used mutably
     println!("{:?}", x);
 }
 async fn a2(x: &mut i32, y: String) {
-    //~^ ERROR: this argument is a mutable reference, but not used mutably
+    //~^ ERROR: this argument is a mutable reference, but never used mutably
     println!("{:?}", x);
 }
 async fn a3(x: &mut i32, y: String, z: String) {
-    //~^ ERROR: this argument is a mutable reference, but not used mutably
+    //~^ ERROR: this argument is a mutable reference, but never used mutably
     println!("{:?}", x);
 }
 async fn a4(x: &mut i32, y: i32) {
-    //~^ ERROR: this argument is a mutable reference, but not used mutably
+    //~^ ERROR: this argument is a mutable reference, but never used mutably
     println!("{:?}", x);
 }
 async fn a5(x: i32, y: &mut i32) {
-    //~^ ERROR: this argument is a mutable reference, but not used mutably
+    //~^ ERROR: this argument is a mutable reference, but never used mutably
     println!("{:?}", x);
 }
 async fn a6(x: i32, y: &mut i32) {
-    //~^ ERROR: this argument is a mutable reference, but not used mutably
+    //~^ ERROR: this argument is a mutable reference, but never used mutably
     println!("{:?}", x);
 }
 async fn a7(x: i32, y: i32, z: &mut i32) {
-    //~^ ERROR: this argument is a mutable reference, but not used mutably
+    //~^ ERROR: this argument is a mutable reference, but never used mutably
     println!("{:?}", z);
 }
 async fn a8(x: i32, a: &mut i32, y: i32, z: &mut i32) {
-    //~^ ERROR: this argument is a mutable reference, but not used mutably
+    //~^ ERROR: this argument is a mutable reference, but never used mutably
     println!("{:?}", z);
 }
 
@@ -186,14 +186,14 @@ fn lint_attr(s: &mut u32) {}
 
 #[cfg(not(feature = "a"))]
 fn cfg_warn(s: &mut u32) {}
-//~^ ERROR: this argument is a mutable reference, but not used mutably
-//~| NOTE: this is cfg-gated and may require further changes
+//~^ ERROR: this argument is a mutable reference, but never used mutably
+//~| NOTE: this is `cfg`-gated and may require further changes
 
 #[cfg(not(feature = "a"))]
 mod foo {
     fn cfg_warn(s: &mut u32) {}
-    //~^ ERROR: this argument is a mutable reference, but not used mutably
-    //~| NOTE: this is cfg-gated and may require further changes
+    //~^ ERROR: this argument is a mutable reference, but never used mutably
+    //~| NOTE: this is `cfg`-gated and may require further changes
 }
 
 fn main() {
diff --git a/tests/ui/needless_pass_by_ref_mut.stderr b/tests/ui/needless_pass_by_ref_mut.stderr
@@ -84,15 +84,15 @@ error: this argument is a mutable reference, but never used mutably
 LL | fn cfg_warn(s: &mut u32) {}
    |                ^^^^^^^^ help: consider using an immutable reference instead: `&u32`
    |
-   = note: this is cfg-gated and may require further changes
+   = note: this is `cfg`-gated and may require further changes
 
 error: this argument is a mutable reference, but never used mutably
   --> $DIR/needless_pass_by_ref_mut.rs:194:20
    |
 LL |     fn cfg_warn(s: &mut u32) {}
    |                    ^^^^^^^^ help: consider using an immutable reference instead: `&u32`
    |
-   = note: this is cfg-gated and may require further changes
+   = note: this is `cfg`-gated and may require further changes
 
 error: aborting due to 15 previous errors
 

Original file line number	Diff line number	Diff line change
`@@ -214,7 +214,7 @@ impl<'tcx> LateLintPass<'tcx> for NeedlessPassByRefMut<'tcx> {`
`214`	`214`	`diag.warn("changing this function will impact semver compatibility");`
`215`	`215`	`}`
`216`	`216`	`if *is_cfged {`
`217`		`- diag.note("this is cfg-gated and may require further changes");`
	`217`	+ diag.note("this is `cfg`-gated and may require further changes");
`218`	`218`	`}`
`219`	`219`	`},`
`220`	`220`	`);`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ declare_clippy_lint! {`
`37`	`37`	/// ```
`38`	`38`	`#[clippy::version = "1.72.0"]`
`39`	`39`	`pub TUPLE_ARRAY_CONVERSIONS,`
`40`		`- nursery,`
	`40`	`+ pedantic,`
`41`	`41`	"checks for tuple<=>array conversions that are not done with `.into()`"
`42`	`42`	`}`
`43`	`43`	`impl_lint_pass!(TupleArrayConversions => [TUPLE_ARRAY_CONVERSIONS]);`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`use std::ptr::NonNull;`
`5`	`5`
`6`	`6`	`fn foo(s: &mut Vec<u32>, b: &u32, x: &mut u32) {`
`7`		`- //~^ ERROR: this argument is a mutable reference, but not used mutably`
	`7`	`+ //~^ ERROR: this argument is a mutable reference, but never used mutably`
`8`	`8`	`x += b + s.len() as u32;`
`9`	`9`	`}`
`10`	`10`
`@@ -29,7 +29,7 @@ fn foo5(s: &mut Vec<u32>) {`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`fn foo6(s: &mut Vec<u32>) {`
`32`		`- //~^ ERROR: this argument is a mutable reference, but not used mutably`
	`32`	`+ //~^ ERROR: this argument is a mutable reference, but never used mutably`
`33`	`33`	`non_mut_ref(s);`
`34`	`34`	`}`
`35`	`35`
`@@ -42,12 +42,12 @@ impl Bar {`
`42`	`42`	`fn bar(&mut self) {}`
`43`	`43`
`44`	`44`	`fn mushroom(&self, vec: &mut Vec<i32>) -> usize {`
`45`		`- //~^ ERROR: this argument is a mutable reference, but not used mutably`
	`45`	`+ //~^ ERROR: this argument is a mutable reference, but never used mutably`
`46`	`46`	`vec.len()`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`fn badger(&mut self, vec: &mut Vec<i32>) -> usize {`
`50`		`- //~^ ERROR: this argument is a mutable reference, but not used mutably`
	`50`	`+ //~^ ERROR: this argument is a mutable reference, but never used mutably`
`51`	`51`	`vec.len()`
`52`	`52`	`}`
`53`	`53`	`}`
`@@ -124,35 +124,35 @@ async fn f7(x: &mut i32, y: i32, z: &mut i32, a: i32) {`
`124`	`124`	`}`
`125`	`125`
`126`	`126`	`async fn a1(x: &mut i32) {`
`127`		`- //~^ ERROR: this argument is a mutable reference, but not used mutably`
	`127`	`+ //~^ ERROR: this argument is a mutable reference, but never used mutably`
`128`	`128`	`println!("{:?}", x);`
`129`	`129`	`}`
`130`	`130`	`async fn a2(x: &mut i32, y: String) {`
`131`		`- //~^ ERROR: this argument is a mutable reference, but not used mutably`
	`131`	`+ //~^ ERROR: this argument is a mutable reference, but never used mutably`
`132`	`132`	`println!("{:?}", x);`
`133`	`133`	`}`
`134`	`134`	`async fn a3(x: &mut i32, y: String, z: String) {`
`135`		`- //~^ ERROR: this argument is a mutable reference, but not used mutably`
	`135`	`+ //~^ ERROR: this argument is a mutable reference, but never used mutably`
`136`	`136`	`println!("{:?}", x);`
`137`	`137`	`}`
`138`	`138`	`async fn a4(x: &mut i32, y: i32) {`
`139`		`- //~^ ERROR: this argument is a mutable reference, but not used mutably`
	`139`	`+ //~^ ERROR: this argument is a mutable reference, but never used mutably`
`140`	`140`	`println!("{:?}", x);`
`141`	`141`	`}`
`142`	`142`	`async fn a5(x: i32, y: &mut i32) {`
`143`		`- //~^ ERROR: this argument is a mutable reference, but not used mutably`
	`143`	`+ //~^ ERROR: this argument is a mutable reference, but never used mutably`
`144`	`144`	`println!("{:?}", x);`
`145`	`145`	`}`
`146`	`146`	`async fn a6(x: i32, y: &mut i32) {`
`147`		`- //~^ ERROR: this argument is a mutable reference, but not used mutably`
	`147`	`+ //~^ ERROR: this argument is a mutable reference, but never used mutably`
`148`	`148`	`println!("{:?}", x);`
`149`	`149`	`}`
`150`	`150`	`async fn a7(x: i32, y: i32, z: &mut i32) {`
`151`		`- //~^ ERROR: this argument is a mutable reference, but not used mutably`
	`151`	`+ //~^ ERROR: this argument is a mutable reference, but never used mutably`
`152`	`152`	`println!("{:?}", z);`
`153`	`153`	`}`
`154`	`154`	`async fn a8(x: i32, a: &mut i32, y: i32, z: &mut i32) {`
`155`		`- //~^ ERROR: this argument is a mutable reference, but not used mutably`
	`155`	`+ //~^ ERROR: this argument is a mutable reference, but never used mutably`
`156`	`156`	`println!("{:?}", z);`
`157`	`157`	`}`
`158`	`158`
`@@ -186,14 +186,14 @@ fn lint_attr(s: &mut u32) {}`
`186`	`186`
`187`	`187`	`#[cfg(not(feature = "a"))]`
`188`	`188`	`fn cfg_warn(s: &mut u32) {}`
`189`		`-//~^ ERROR: this argument is a mutable reference, but not used mutably`
`190`		`-//~\| NOTE: this is cfg-gated and may require further changes`
	`189`	`+//~^ ERROR: this argument is a mutable reference, but never used mutably`
	`190`	+//~\| NOTE: this is `cfg`-gated and may require further changes
`191`	`191`
`192`	`192`	`#[cfg(not(feature = "a"))]`
`193`	`193`	`mod foo {`
`194`	`194`	`fn cfg_warn(s: &mut u32) {}`
`195`		`- //~^ ERROR: this argument is a mutable reference, but not used mutably`
`196`		`- //~\| NOTE: this is cfg-gated and may require further changes`
	`195`	`+ //~^ ERROR: this argument is a mutable reference, but never used mutably`
	`196`	+ //~\| NOTE: this is `cfg`-gated and may require further changes
`197`	`197`	`}`
`198`	`198`
`199`	`199`	`fn main() {`
Original file line number	Diff line number	Diff line change
`@@ -84,15 +84,15 @@ error: this argument is a mutable reference, but never used mutably`
`84`	`84`	`LL \| fn cfg_warn(s: &mut u32) {}`
`85`	`85`	\| ^^^^^^^^ help: consider using an immutable reference instead: `&u32`
`86`	`86`	`\|`
`87`		`- = note: this is cfg-gated and may require further changes`
	`87`	+ = note: this is `cfg`-gated and may require further changes
`88`	`88`
`89`	`89`	`error: this argument is a mutable reference, but never used mutably`
`90`	`90`	`--> $DIR/needless_pass_by_ref_mut.rs:194:20`
`91`	`91`	`\|`
`92`	`92`	`LL \| fn cfg_warn(s: &mut u32) {}`
`93`	`93`	\| ^^^^^^^^ help: consider using an immutable reference instead: `&u32`
`94`	`94`	`\|`
`95`		`- = note: this is cfg-gated and may require further changes`
	`95`	+ = note: this is `cfg`-gated and may require further changes
`96`	`96`
`97`	`97`	`error: aborting due to 15 previous errors`
`98`	`98`