Skip to content

Commit 0dd5ff1

Browse files
petrochenkovpetrochenkov
committed
Rename MetaItem::ident to MetaItem::path 
1 parent 37e7ae1 commit 0dd5ff1

File tree

16 files changed

+52
-53
lines changed

16 files changed

+52
-53
lines changed

‎src/librustc/ich/impls_syntax.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@ impl_stable_hash_for!(enum ::syntax::ast::NestedMetaItemKind {
368368
});
369369

370370
impl_stable_hash_for!(struct ::syntax::ast::MetaItem {
371-
ident,
371+
path,
372372
node,
373373
span
374374
});

‎src/librustc/lint/levels.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ impl<'a> LintLevelsBuilder<'a> {
220220
match item.node {
221221
ast::MetaItemKind::Word => {} // actual lint names handled later
222222
ast::MetaItemKind::NameValue(ref name_value) => {
223-
if item.ident == "reason" {
223+
if item.path == "reason" {
224224
// found reason, reslice meta list to exclude it
225225
metas = &metas[0..metas.len()-1];
226226
// FIXME (#55112): issue unused-attributes lint if we thereby
@@ -260,7 +260,7 @@ impl<'a> LintLevelsBuilder<'a> {
260260
let mut err = bad_attr(li.span);
261261
if let Some(item) = li.meta_item() {
262262
if let ast::MetaItemKind::NameValue(_) = item.node {
263-
if item.ident == "reason" {
263+
if item.path == "reason" {
264264
err.help("reason in lint attribute must come last");
265265
}
266266
}
@@ -269,15 +269,15 @@ impl<'a> LintLevelsBuilder<'a> {
269269
continue;
270270
}
271271
};
272-
let tool_name = if meta_item.ident.segments.len() > 1 {
273-
let tool_ident = meta_item.ident.segments[0].ident;
272+
let tool_name = if meta_item.path.segments.len() > 1 {
273+
let tool_ident = meta_item.path.segments[0].ident;
274274
if !attr::is_known_lint_tool(tool_ident) {
275275
span_err!(
276276
sess,
277277
tool_ident.span,
278278
E0710,
279279
"an unknown tool name found in scoped lint: `{}`",
280-
meta_item.ident
280+
meta_item.path
281281
);
282282
continue;
283283
}
@@ -286,7 +286,7 @@ impl<'a> LintLevelsBuilder<'a> {
286286
} else {
287287
None
288288
};
289-
let name = meta_item.ident.segments.last().expect("empty lint name").ident.name;
289+
let name = meta_item.path.segments.last().expect("empty lint name").ident.name;
290290
match store.check_lint_name(&name.as_str(), tool_name) {
291291
CheckLintNameResult::Ok(ids) => {
292292
let src = LintSource::Node(name, li.span, reason);

‎src/librustc/session/config.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1806,7 +1806,7 @@ pub fn parse_cfgspecs(cfgspecs: Vec<String>) -> ast::CrateConfig {
18061806

18071807
match &mut parser.parse_meta_item() {
18081808
Ok(meta_item) if parser.token == token::Eof => {
1809-
if meta_item.ident.segments.len() != 1 {
1809+
if meta_item.path.segments.len() != 1 {
18101810
error!("argument key must be an identifier");
18111811
}
18121812
match &meta_item.node {

‎src/librustc_driver/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -798,7 +798,7 @@ impl RustcDefaultCalls {
798798

799799
let mut cfgs = sess.parse_sess.config.iter().filter_map(|&(name, ref value)| {
800800
let gated_cfg = GatedCfg::gate(&ast::MetaItem {
801-
ident: ast::Path::from_ident(ast::Ident::with_empty_ctxt(name)),
801+
path: ast::Path::from_ident(ast::Ident::with_empty_ctxt(name)),
802802
node: ast::MetaItemKind::Word,
803803
span: DUMMY_SP,
804804
});

‎src/librustc_mir/dataflow/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ impl<'a, 'gcx: 'tcx, 'tcx: 'a, BD> DataflowAnalysis<'a, 'tcx, BD> where BD: BitD
145145
} else {
146146
sess.span_err(
147147
item.span,
148-
&format!("{} attribute requires a path", item.ident));
148+
&format!("{} attribute requires a path", item.path));
149149
return None;
150150
}
151151
}

‎src/librustdoc/clean/cfg.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -430,7 +430,7 @@ mod test {
430430

431431
fn dummy_meta_item_word(name: &str) -> MetaItem {
432432
MetaItem {
433-
ident: Path::from_ident(Ident::from_str(name)),
433+
path: Path::from_ident(Ident::from_str(name)),
434434
node: MetaItemKind::Word,
435435
span: DUMMY_SP,
436436
}
@@ -439,7 +439,7 @@ mod test {
439439
macro_rules! dummy_meta_item_list {
440440
($name:ident, [$($list:ident),* $(,)?]) => {
441441
MetaItem {
442-
ident: Path::from_ident(Ident::from_str(stringify!($name))),
442+
path: Path::from_ident(Ident::from_str(stringify!($name))),
443443
node: MetaItemKind::List(vec![
444444
$(
445445
dummy_spanned(NestedMetaItemKind::MetaItem(
@@ -453,7 +453,7 @@ mod test {
453453

454454
($name:ident, [$($list:expr),* $(,)?]) => {
455455
MetaItem {
456-
ident: Path::from_ident(Ident::from_str(stringify!($name))),
456+
path: Path::from_ident(Ident::from_str(stringify!($name))),
457457
node: MetaItemKind::List(vec![
458458
$(
459459
dummy_spanned(NestedMetaItemKind::MetaItem($list)),
@@ -593,7 +593,7 @@ mod test {
593593
assert_eq!(Cfg::parse(&mi), Ok(word_cfg("all")));
594594

595595
let mi = MetaItem {
596-
ident: Path::from_ident(Ident::from_str("all")),
596+
path: Path::from_ident(Ident::from_str("all")),
597597
node: MetaItemKind::NameValue(dummy_spanned(LitKind::Str(
598598
Symbol::intern("done"),
599599
StrStyle::Cooked,
@@ -628,7 +628,7 @@ mod test {
628628
fn test_parse_err() {
629629
with_globals(|| {
630630
let mi = MetaItem {
631-
ident: Path::from_ident(Ident::from_str("foo")),
631+
path: Path::from_ident(Ident::from_str("foo")),
632632
node: MetaItemKind::NameValue(dummy_spanned(LitKind::Bool(false))),
633633
span: DUMMY_SP,
634634
};

‎src/librustdoc/html/render.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3717,7 +3717,7 @@ fn item_enum(w: &mut fmt::Formatter<'_>, cx: &Context, it: &clean::Item,
37173717
}
37183718

37193719
fn render_attribute(attr: &ast::MetaItem) -> Option<String> {
3720-
let path = attr.ident.to_string();
3720+
let path = attr.path.to_string();
37213721

37223722
if attr.is_word() {
37233723
Some(path)

‎src/libsyntax/ast.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -464,7 +464,7 @@ pub enum NestedMetaItemKind {
464464
/// E.g., `#[test]`, `#[derive(..)]`, `#[rustfmt::skip]` or `#[feature = "foo"]`.
465465
#[derive(Clone, RustcEncodable, RustcDecodable, Debug)]
466466
pub struct MetaItem {
467-
pub ident: Path,
467+
pub path: Path,
468468
pub node: MetaItemKind,
469469
pub span: Span,
470470
}

‎src/libsyntax/attr/builtin.rs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ fn find_stability_generic<'a, I>(sess: &ParseSess,
217217
let meta = meta.as_ref().unwrap();
218218
let get = |meta: &MetaItem, item: &mut Option<Symbol>| {
219219
if item.is_some() {
220-
handle_errors(sess, meta.span, AttrError::MultipleItem(meta.ident.to_string()));
220+
handle_errors(sess, meta.span, AttrError::MultipleItem(meta.path.to_string()));
221221
return false
222222
}
223223
if let Some(v) = meta.value_str() {
@@ -246,7 +246,7 @@ fn find_stability_generic<'a, I>(sess: &ParseSess,
246246
handle_errors(
247247
sess,
248248
mi.span,
249-
AttrError::UnknownMetaItem(mi.ident.to_string(), expected),
249+
AttrError::UnknownMetaItem(mi.path.to_string(), expected),
250250
);
251251
continue 'outer
252252
}
@@ -329,7 +329,7 @@ fn find_stability_generic<'a, I>(sess: &ParseSess,
329329
sess,
330330
meta.span,
331331
AttrError::UnknownMetaItem(
332-
mi.ident.to_string(),
332+
mi.path.to_string(),
333333
&["feature", "reason", "issue"]
334334
),
335335
);
@@ -401,7 +401,7 @@ fn find_stability_generic<'a, I>(sess: &ParseSess,
401401
sess,
402402
meta.span,
403403
AttrError::UnknownMetaItem(
404-
mi.ident.to_string(), &["since", "note"],
404+
mi.path.to_string(), &["since", "note"],
405405
),
406406
);
407407
continue 'outer
@@ -496,8 +496,8 @@ pub fn cfg_matches(cfg: &ast::MetaItem, sess: &ParseSess, features: Option<&Feat
496496
gated_cfg.check_and_emit(sess, feats);
497497
}
498498
let error = |span, msg| { sess.span_diagnostic.span_err(span, msg); true };
499-
if cfg.ident.segments.len() != 1 {
500-
return error(cfg.ident.span, "`cfg` predicate key must be an identifier");
499+
if cfg.path.segments.len() != 1 {
500+
return error(cfg.path.span, "`cfg` predicate key must be an identifier");
501501
}
502502
match &cfg.node {
503503
MetaItemKind::List(..) => {
@@ -563,7 +563,7 @@ pub fn eval_condition<F>(cfg: &ast::MetaItem, sess: &ParseSess, eval: &mut F)
563563
},
564564
_ => {
565565
span_err!(sess.span_diagnostic, cfg.span, E0537,
566-
"invalid predicate `{}`", cfg.ident);
566+
"invalid predicate `{}`", cfg.path);
567567
false
568568
}
569569
}
@@ -618,7 +618,7 @@ fn find_deprecation_generic<'a, I>(sess: &ParseSess,
618618
let get = |meta: &MetaItem, item: &mut Option<Symbol>| {
619619
if item.is_some() {
620620
handle_errors(
621-
sess, meta.span, AttrError::MultipleItem(meta.ident.to_string())
621+
sess, meta.span, AttrError::MultipleItem(meta.path.to_string())
622622
);
623623
return false
624624
}
@@ -656,7 +656,7 @@ fn find_deprecation_generic<'a, I>(sess: &ParseSess,
656656
handle_errors(
657657
sess,
658658
meta.span(),
659-
AttrError::UnknownMetaItem(mi.ident.to_string(),
659+
AttrError::UnknownMetaItem(mi.path.to_string(),
660660
&["since", "note"]),
661661
);
662662
continue 'outer

‎src/libsyntax/attr/mod.rs

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -208,8 +208,8 @@ impl Attribute {
208208
impl MetaItem {
209209
/// For a single-segment meta-item returns its name, otherwise returns `None`.
210210
pub fn ident(&self) -> Option<Ident> {
211-
if self.ident.segments.len() == 1 {
212-
Some(self.ident.segments[0].ident)
211+
if self.path.segments.len() == 1 {
212+
Some(self.path.segments[0].ident)
213213
} else {
214214
None
215215
}
@@ -256,7 +256,7 @@ impl MetaItem {
256256
pub fn span(&self) -> Span { self.span }
257257

258258
pub fn check_name(&self, name: &str) -> bool {
259-
self.ident == name
259+
self.path == name
260260
}
261261

262262
pub fn is_value_str(&self) -> bool {
@@ -273,7 +273,7 @@ impl Attribute {
273273
pub fn meta(&self) -> Option<MetaItem> {
274274
let mut tokens = self.tokens.trees().peekable();
275275
Some(MetaItem {
276-
ident: self.path.clone(),
276+
path: self.path.clone(),
277277
node: if let Some(node) = MetaItemKind::from_tokens(&mut tokens) {
278278
if tokens.peek().is_some() {
279279
return None;
@@ -319,7 +319,7 @@ impl Attribute {
319319

320320
pub fn parse_meta<'a>(&self, sess: &'a ParseSess) -> PResult<'a, MetaItem> {
321321
Ok(MetaItem {
322-
ident: self.path.clone(),
322+
path: self.path.clone(),
323323
node: self.parse(sess, |parser| parser.parse_meta_item_kind())?,
324324
span: self.span,
325325
})
@@ -357,15 +357,15 @@ pub fn mk_name_value_item_str(ident: Ident, value: Spanned<Symbol>) -> MetaItem
357357
}
358358

359359
pub fn mk_name_value_item(span: Span, ident: Ident, value: ast::Lit) -> MetaItem {
360-
MetaItem { ident: Path::from_ident(ident), span, node: MetaItemKind::NameValue(value) }
360+
MetaItem { path: Path::from_ident(ident), span, node: MetaItemKind::NameValue(value) }
361361
}
362362

363363
pub fn mk_list_item(span: Span, ident: Ident, items: Vec<NestedMetaItem>) -> MetaItem {
364-
MetaItem { ident: Path::from_ident(ident), span, node: MetaItemKind::List(items) }
364+
MetaItem { path: Path::from_ident(ident), span, node: MetaItemKind::List(items) }
365365
}
366366

367367
pub fn mk_word_item(ident: Ident) -> MetaItem {
368-
MetaItem { ident: Path::from_ident(ident), span: ident.span, node: MetaItemKind::Word }
368+
MetaItem { path: Path::from_ident(ident), span: ident.span, node: MetaItemKind::Word }
369369
}
370370

371371
pub fn mk_nested_word_item(ident: Ident) -> NestedMetaItem {
@@ -393,7 +393,7 @@ pub fn mk_spanned_attr_inner(sp: Span, id: AttrId, item: MetaItem) -> Attribute
393393
Attribute {
394394
id,
395395
style: ast::AttrStyle::Inner,
396-
path: item.ident,
396+
path: item.path,
397397
tokens: item.node.tokens(item.span),
398398
is_sugared_doc: false,
399399
span: sp,
@@ -410,7 +410,7 @@ pub fn mk_spanned_attr_outer(sp: Span, id: AttrId, item: MetaItem) -> Attribute
410410
Attribute {
411411
id,
412412
style: ast::AttrStyle::Outer,
413-
path: item.ident,
413+
path: item.path,
414414
tokens: item.node.tokens(item.span),
415415
is_sugared_doc: false,
416416
span: sp,
@@ -461,7 +461,7 @@ impl MetaItem {
461461
fn tokens(&self) -> TokenStream {
462462
let mut idents = vec![];
463463
let mut last_pos = BytePos(0 as u32);
464-
for (i, segment) in self.ident.segments.iter().enumerate() {
464+
for (i, segment) in self.path.segments.iter().enumerate() {
465465
let is_first = i == 0;
466466
if !is_first {
467467
let mod_sep_span = Span::new(last_pos,
@@ -481,7 +481,7 @@ impl MetaItem {
481481
where I: Iterator<Item = TokenTree>,
482482
{
483483
// FIXME: Share code with `parse_path`.
484-
let ident = match tokens.next() {
484+
let path = match tokens.next() {
485485
Some(TokenTree::Token(span, token @ Token::Ident(..))) |
486486
Some(TokenTree::Token(span, token @ Token::ModSep)) => 'arm: {
487487
let mut segments = if let Token::Ident(ident, _) = token {
@@ -522,11 +522,11 @@ impl MetaItem {
522522
let node = MetaItemKind::from_tokens(tokens)?;
523523
let hi = match node {
524524
MetaItemKind::NameValue(ref lit) => lit.span.hi(),
525-
MetaItemKind::List(..) => list_closing_paren_pos.unwrap_or(ident.span.hi()),
526-
_ => ident.span.hi(),
525+
MetaItemKind::List(..) => list_closing_paren_pos.unwrap_or(path.span.hi()),
526+
_ => path.span.hi(),
527527
};
528-
let span = ident.span.with_hi(hi);
529-
Some(MetaItem { ident, node, span })
528+
let span = path.span.with_hi(hi);
529+
Some(MetaItem { path, node, span })
530530
}
531531
}
532532

‎src/libsyntax/ext/expand.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -929,7 +929,7 @@ impl<'a, 'b> MacroExpander<'a, 'b> {
929929
invoc.expansion_data.mark.set_expn_info(expn_info);
930930
let span = span.with_ctxt(self.cx.backtrace());
931931
let dummy = ast::MetaItem { // FIXME(jseyfried) avoid this
932-
ident: Path::from_ident(keywords::Invalid.ident()),
932+
path: Path::from_ident(keywords::Invalid.ident()),
933933
span: DUMMY_SP,
934934
node: ast::MetaItemKind::Word,
935935
};

‎src/libsyntax/mut_visit.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -548,7 +548,7 @@ pub fn noop_visit_meta_list_item<T: MutVisitor>(li: &mut NestedMetaItem, vis: &m
548548
}
549549

550550
pub fn noop_visit_meta_item<T: MutVisitor>(mi: &mut MetaItem, vis: &mut T) {
551-
let MetaItem { ident: _, node, span } = mi;
551+
let MetaItem { path: _, node, span } = mi;
552552
match node {
553553
MetaItemKind::Word => {}
554554
MetaItemKind::List(mis) => visit_vec(mis, |mi| vis.visit_meta_list_item(mi)),
@@ -1340,4 +1340,3 @@ mod tests {
13401340
})
13411341
}
13421342
}
1343-

‎src/libsyntax/parse/attr.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ impl<'a> Parser<'a> {
149149
};
150150
Ok(if let Some(meta) = meta {
151151
self.bump();
152-
(meta.ident, meta.node.tokens(meta.span))
152+
(meta.path, meta.node.tokens(meta.span))
153153
} else {
154154
let path = self.parse_path(PathStyle::Mod)?;
155155
let tokens = if self.check(&token::OpenDelim(DelimToken::Paren)) ||
@@ -250,10 +250,10 @@ impl<'a> Parser<'a> {
250250
}
251251

252252
let lo = self.span;
253-
let ident = self.parse_path(PathStyle::Mod)?;
253+
let path = self.parse_path(PathStyle::Mod)?;
254254
let node = self.parse_meta_item_kind()?;
255255
let span = lo.to(self.prev_span);
256-
Ok(ast::MetaItem { ident, node, span })
256+
Ok(ast::MetaItem { path, node, span })
257257
}
258258

259259
crate fn parse_meta_item_kind(&mut self) -> PResult<'a, ast::MetaItemKind> {

‎src/libsyntax/parse/parser.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2318,7 +2318,7 @@ impl<'a> Parser<'a> {
23182318
let meta_ident = match self.token {
23192319
token::Interpolated(ref nt) => match **nt {
23202320
token::NtMeta(ref meta) => match meta.node {
2321-
ast::MetaItemKind::Word => Some(meta.ident.clone()),
2321+
ast::MetaItemKind::Word => Some(meta.path.clone()),
23222322
_ => None,
23232323
},
23242324
_ => None,

0 commit comments

Comments
 (0)