Skip to content

[WIP] Navigation Preferences #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

aaryankotharii
Copy link
Member

Description

  • added NavigationPreferences Model
  • added NavigationPreferencesView

Related Issue

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • I documented my code
  • Review requested

Screenshots

CodeEdit Xcode
Screenshot 2022-10-03 at 11 50 02 PM xcode

@StateObject
private var prefs: AppPreferencesModel = .shared

public init() { }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Please fix trailing whitespace violation.

@austincondiff austincondiff linked an issue Oct 4, 2022 that may be closed by this pull request
@matthijseikelenboom
Copy link
Contributor

Maybe convert this to a draft PR?

@austincondiff austincondiff marked this pull request as draft October 6, 2022 14:57
@austincondiff
Copy link
Collaborator

@aaryankotharii How is this coming along? Let me know if you need anything.

@austincondiff
Copy link
Collaborator

@aaryankotharii How close is this to being complete? Are you able to wrap this up? If not let me know so someone else can.

@lukepistrol
Copy link
Member

Closing this due to inactivity

@lukepistrol lukepistrol closed this Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Navigation Settings
4 participants