Skip to content

Fix typescript errors with Vue 3 #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Fix typescript errors with Vue 3 #741

merged 1 commit into from
Jan 10, 2022

Conversation

Demivan
Copy link
Member

@Demivan Demivan commented Jan 8, 2022

Fixes #740

@Demivan Demivan added the Type: Bug Something isn't working label Jan 8, 2022
@github-actions
Copy link

github-actions bot commented Jan 8, 2022

Export Size

Unchanged

fluent-vue

Name Size Diff
createFluentVue 1.96 KB -
useFluent 871 B -

@codecov
Copy link

codecov bot commented Jan 8, 2022

Codecov Report

Merging #741 (ed02121) into main (1fb3fb5) will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #741      +/-   ##
==========================================
- Coverage   99.62%   99.43%   -0.19%     
==========================================
  Files          10       10              
  Lines         530      530              
  Branches       82       41      -41     
==========================================
- Hits          528      527       -1     
- Misses          1        3       +2     
+ Partials        1        0       -1     
Flag Coverage Δ
vue-2 99.43% <ø> (+5.09%) ⬆️
vue-3 98.67% <ø> (+4.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/getContext.ts 98.38% <0.00%> (-1.62%) ⬇️
src/vue/directive.ts 98.49% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fb3fb5...ed02121. Read the comment docs.

@Demivan Demivan merged commit 879c2d3 into main Jan 10, 2022
@Demivan Demivan deleted the fix-vue-3-types branch January 24, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Development

Successfully merging this pull request may close these issues.

Wrong resolution to Vue 2 when in Vue 3 project
1 participant