- Address feedback

Author: nwithan8

src/main/java/com/easypost/easyvcr/MatchRules.java

@@ -58,8 +58,13 @@ public MatchRules byBaseUrl() {
         return this;
     }
 
+    /**
+     * Extract the base URL from a URI.
+     *
+     * @param url The URI to extract the base URL from.
+     * @return The base URL.
+     */
     private static String getBaseUrl(URI url) {
-
         String baseUrl = url.getScheme() + "://" + url.getHost();
         if (url.getPort() != -1) {
             baseUrl += ":" + url.getPort();

src/main/java/com/easypost/easyvcr/clients/httpurlconnection/RecordableHttpURLConnection.java

@@ -144,6 +144,11 @@ public RecordableHttpURLConnection(URL url, Cassette cassette, Mode mode)
         this(url, cassette, mode, new AdvancedSettings());
     }
 
+    /**
+     * Throws an exception if a matching interaction has not been cached.
+     *
+     * @throws VCRException If the interaction has not been cached.
+     */
     private void cachedInteractionExistsOtherwiseError() throws VCRException {
         if (this.cachedInteraction == null) {
             throw new VCRException("No matching interaction found.");

src/main/java/com/easypost/easyvcr/clients/httpurlconnection/RecordableHttpsURLConnection.java

@@ -149,6 +149,11 @@ public RecordableHttpsURLConnection(URL url, Cassette cassette, Mode mode)
         this(url, cassette, mode, new AdvancedSettings());
     }
 
+    /**
+     * Throws an exception if a matching interaction has not been cached.
+     *
+     * @throws VCRException If the interaction has not been cached.
+     */
     private void cachedInteractionExistsOtherwiseError() throws VCRException {
         if (this.cachedInteraction == null) {
             throw new VCRException("No matching interaction found.");

src/test/java/HttpUrlConnectionTest.java

@@ -560,8 +560,17 @@ public void testCachedInteractionDoesNotExist() throws Exception {
                 url + "1", cassette, Mode.Replay, advancedSettings);
         // make HTTP call (attempt replay from cassette)
         connection.connect();
+
         // Attempt to pull data (e.g. body) from the response (via the input stream)
         // this throws a RuntimeException because of the way the exceptions are coalesced internally
-        Assert.assertThrows(RuntimeException.class, connection::getInputStream);
+        try {
+            connection.getInputStream();
+            // if we get here, the exception was not thrown as expected
+            Assert.fail();
+        } catch (Exception e) {
+            Assert.assertTrue(e instanceof RuntimeException);
+            Assert.assertTrue(e.getCause() instanceof VCRException);
+            Assert.assertEquals(e.getCause().getMessage(), "No matching interaction found.");
+        }
     }
 }