Experiment with never creating directory symlinks

This change is wrong and should never be merged to main, nor
otherwise ever be present in any release.

The point of this is just to check if anything in the test suite
currently catches the creation of file symlinks in a situation
where a directory symlink should be created.

Author: EliahKagan

gix-fs/src/symlink.rs

@@ -33,24 +33,12 @@ pub fn remove(path: &Path) -> io::Result<()> {
 
 /// Create a new symlink at `link` which points to `original`.
 ///
-/// Note that if a symlink target (the `original`) isn't present on disk, it's assumed to be a
-/// file, creating a dangling file symlink. This is similar to a dangling symlink on Unix,
-/// which doesn't have to care about the target type though.
+/// This temporarily broken implementation is to test the test suite.
+/// In real life, we should sometimes create directory symlinks!
+/// This change should not be merged and should not appear in any releases!!
 #[cfg(windows)]
 pub fn create(original: &Path, link: &Path) -> io::Result<()> {
-    use std::os::windows::fs::{symlink_dir, symlink_file};
-    // TODO: figure out if links to links count as files or whatever they point at
-    let orig_abs = link.parent().expect("dir for link").join(original);
-    let is_dir = match std::fs::metadata(orig_abs) {
-        Ok(m) => m.is_dir(),
-        Err(err) if err.kind() == io::ErrorKind::NotFound => false,
-        Err(err) => return Err(err),
-    };
-    if is_dir {
-        symlink_dir(original, link)
-    } else {
-        symlink_file(original, link)
-    }
+    std::os::windows::fs::symlink_file(original, link)
 }
 
 /// Return true if `err` indicates that a file collision happened, i.e. a symlink couldn't be created as the `link`