chore: reduce complexity of getConfig fn

Signed-off-by: Jakub Freisler <[email protected]>

Author: FRSgit

packages/cypress-plugin-visual-regression-diff/src/commands.ts

@@ -80,34 +80,35 @@ const getImagesDir = (options: Cypress.MatchImageOptions) => {
   return imagesDir;
 };
 
-export const getConfig = (options: Cypress.MatchImageOptions) => {
+const getImagesPathConfig = (options: Cypress.MatchImageOptions) => {
   const imagesDir = getImagesDir(options);
 
-  return {
-    scaleFactor:
-      options.forceDeviceScaleFactor === false ||
-      getPluginEnv("forceDeviceScaleFactor") === false
-        ? 1
-        : 1 / window.devicePixelRatio,
-    createMissingImages:
-      options.createMissingImages ??
-      getPluginEnv("createMissingImages") ??
-      true,
-    updateImages: options.updateImages ?? getPluginEnv("updateImages") ?? false,
-    imagesPath:
-      (imagesDir && `{spec_path}/${imagesDir}`) ||
-      options.imagesPath ||
-      getPluginEnv("imagesPath") ||
-      "{spec_path}/__image_snapshots__",
-    maxDiffThreshold:
-      options.maxDiffThreshold ?? getPluginEnv("maxDiffThreshold") ?? 0.01,
-    diffConfig: options.diffConfig || getPluginEnv("diffConfig") || {},
-    screenshotConfig:
-      options.screenshotConfig || getPluginEnv("screenshotConfig") || {},
-    matchAgainstPath: options.matchAgainstPath || undefined,
-  };
+  return (
+    (imagesDir && `{spec_path}/${imagesDir}`) ||
+    options.imagesPath ||
+    getPluginEnv("imagesPath") ||
+    "{spec_path}/__image_snapshots__"
+  );
 };
 
+export const getConfig = (options: Cypress.MatchImageOptions) => ({
+  scaleFactor:
+    options.forceDeviceScaleFactor === false ||
+    getPluginEnv("forceDeviceScaleFactor") === false
+      ? 1
+      : 1 / window.devicePixelRatio,
+  createMissingImages:
+    options.createMissingImages ?? getPluginEnv("createMissingImages") ?? true,
+  updateImages: options.updateImages ?? getPluginEnv("updateImages") ?? false,
+  imagesPath: getImagesPathConfig(options),
+  maxDiffThreshold:
+    options.maxDiffThreshold ?? getPluginEnv("maxDiffThreshold") ?? 0.01,
+  diffConfig: options.diffConfig || getPluginEnv("diffConfig") || {},
+  screenshotConfig:
+    options.screenshotConfig || getPluginEnv("screenshotConfig") || {},
+  matchAgainstPath: options.matchAgainstPath || undefined,
+});
+
 Cypress.Commands.add(
   "matchImage",
   { prevSubject: "optional" },