Skip to content

Commit b0eb828

Browse files
SC llvm teamSC llvm team
SC llvm team
authored and
SC llvm team
committed
Merged main:6bc225e0630f28e83290a43c3d9b25b057fc815a into amd-gfx:4bb4bb5b239f
Local branch amd-gfx 4bb4bb5 Merged main:3ef64f7ab5b8651eab500cd944984379fce5f639 into amd-gfx:3b493b7eeddf Remote branch main 6bc225e [clang-format] Fix a misannotation of redundant r_paren as CastRParen (llvm#105921)
2 parents 4bb4bb5 + 6bc225e commit b0eb828

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

clang/lib/Format/TokenAnnotator.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2875,6 +2875,8 @@ class AnnotatingParser {
28752875
// Search for unexpected tokens.
28762876
for (auto *Prev = BeforeRParen; Prev != LParen; Prev = Prev->Previous) {
28772877
if (Prev->is(tok::r_paren)) {
2878+
if (Prev->is(TT_CastRParen))
2879+
return false;
28782880
Prev = Prev->MatchingParen;
28792881
if (!Prev)
28802882
return false;

clang/unittests/Format/TokenAnnotatorTest.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -747,6 +747,12 @@ TEST_F(TokenAnnotatorTest, UnderstandsCasts) {
747747
EXPECT_TOKEN(Tokens[9], tok::r_paren, TT_CastRParen);
748748
EXPECT_TOKEN(Tokens[10], tok::amp, TT_UnaryOperator);
749749

750+
Tokens = annotate("int result = ((int)a) - b;");
751+
ASSERT_EQ(Tokens.size(), 13u) << Tokens;
752+
EXPECT_TOKEN(Tokens[6], tok::r_paren, TT_CastRParen);
753+
EXPECT_TOKEN(Tokens[8], tok::r_paren, TT_Unknown);
754+
EXPECT_TOKEN(Tokens[9], tok::minus, TT_BinaryOperator);
755+
750756
auto Style = getLLVMStyle();
751757
Style.TypeNames.push_back("Foo");
752758
Tokens = annotate("#define FOO(bar) foo((Foo)&bar)", Style);

llvm/include/llvm/Config/llvm-config.h.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
/* Indicate that this is LLVM compiled from the amd-gfx branch. */
1818
#define LLVM_HAVE_BRANCH_AMD_GFX
19-
#define LLVM_MAIN_REVISION 509549
19+
#define LLVM_MAIN_REVISION 509550
2020

2121
/* Define if LLVM_ENABLE_DUMP is enabled */
2222
#cmakedefine LLVM_ENABLE_DUMP

0 commit comments

Comments
 (0)