Remove use of reference lifetime extension introduced in cdde0d9

dwblaikie · dwblaikie · commit f15a790fd383 · 2024-03-13T16:03:16.000Z
Rather than dealing with which is more readable, the named variable
doesn't seem to add value here - so omit it.
diff --git a/clang/lib/AST/Interp/Interp.h b/clang/lib/AST/Interp/Interp.h
@@ -846,8 +846,7 @@ bool CMP3(InterpState &S, CodePtr OpPC, const ComparisonCategoryInfo *CmpInfo) {
       CmpInfo->getValueInfo(CmpInfo->makeWeakResult(CmpResult));
   assert(CmpValueInfo);
   assert(CmpValueInfo->hasValidIntValue());
-  const APSInt &IntValue = CmpValueInfo->getIntValue();
-  return SetThreeWayComparisonField(S, OpPC, P, IntValue);
+  return SetThreeWayComparisonField(S, OpPC, P, CmpValueInfo->getIntValue());
 }
 
 template <PrimType Name, class T = typename PrimConv<Name>::T>

Original file line number	Diff line number	Diff line change
`@@ -846,8 +846,7 @@ bool CMP3(InterpState &S, CodePtr OpPC, const ComparisonCategoryInfo *CmpInfo) {`
`846`	`846`	`CmpInfo->getValueInfo(CmpInfo->makeWeakResult(CmpResult));`
`847`	`847`	`assert(CmpValueInfo);`
`848`	`848`	`assert(CmpValueInfo->hasValidIntValue());`
`849`		`- const APSInt &IntValue = CmpValueInfo->getIntValue();`
`850`		`- return SetThreeWayComparisonField(S, OpPC, P, IntValue);`
	`849`	`+ return SetThreeWayComparisonField(S, OpPC, P, CmpValueInfo->getIntValue());`
`851`	`850`	`}`
`852`	`851`
`853`	`852`	`template <PrimType Name, class T = typename PrimConv<Name>::T>`