refactor gix-url tests

Author: Byron

gix-url/src/parse.rs

@@ -114,19 +114,26 @@ pub(crate) fn url(input: &BStr, protocol_end: usize) -> Result<crate::Url, Error
     Ok(crate::Url {
         serialize_alternative_form: false,
         scheme,
-        user: url_user(&url),
-        password: url.password().map(percent_decoded_utf8),
+        user: url_user(&url, UrlKind::Url)?,
+        password: url
+            .password()
+            .map(|s| percent_decoded_utf8(s, UrlKind::Url))
+            .transpose()?,
         host: url.host_str().map(Into::into),
         port: url.port(),
         path: url.path().into(),
     })
 }
 
-fn percent_decoded_utf8(s: &str) -> String {
-    percent_decode_str(s)
+fn percent_decoded_utf8(s: &str, kind: UrlKind) -> Result<String, Error> {
+    Ok(percent_decode_str(s)
         .decode_utf8()
-        .expect("it's not possible to sneak illegal UTF8 into a URL")
-        .into_owned()
+        .map_err(|err| Error::Utf8 {
+            url: s.into(),
+            kind,
+            source: err,
+        })?
+        .into_owned())
 }
 
 pub(crate) fn scp(input: &BStr, colon: usize) -> Result<crate::Url, Error> {
@@ -157,19 +164,22 @@ pub(crate) fn scp(input: &BStr, colon: usize) -> Result<crate::Url, Error> {
     Ok(crate::Url {
         serialize_alternative_form: true,
         scheme: url.scheme().into(),
-        user: url_user(&url),
-        password: url.password().map(percent_decoded_utf8),
+        user: url_user(&url, UrlKind::Scp)?,
+        password: url
+            .password()
+            .map(|s| percent_decoded_utf8(s, UrlKind::Scp))
+            .transpose()?,
         host: url.host_str().map(Into::into),
         port: url.port(),
         path: path.into(),
     })
 }
 
-fn url_user(url: &url::Url) -> Option<String> {
+fn url_user(url: &url::Url, kind: UrlKind) -> Result<Option<String>, Error> {
     if url.username().is_empty() && url.password().is_none() {
-        None
+        Ok(None)
     } else {
-        Some(percent_decoded_utf8(url.username()))
+        Ok(Some(percent_decoded_utf8(url.username(), kind)?))
     }
 }
 

gix-url/tests/fixtures/fuzzed/illegal-utf8.url

@@ -0,0 +1 @@
+BBi%BBBBB,@}:m\

gix-url/tests/access/mod.rs renamed to gix-url/tests/url/access.rs

@@ -164,6 +164,7 @@ fn assert_urls_equal(expected: &baseline::GitDiagUrl<'_>, actual: &gix_url::Url)
     assert_eq!(actual.path, expected.path.unwrap_or_default());
 }
 
+#[allow(clippy::module_inception)]
 mod baseline {
     use bstr::{BStr, BString, ByteSlice};
     use gix_testtools::once_cell::sync::Lazy;

gix-url/tests/baseline.rs renamed to gix-url/tests/url/baseline.rs

@@ -5,6 +5,7 @@ use bstr::ByteSlice;
 #[test]
 fn fuzzed() {
     for name in [
+        "illegal-utf8",
         "short-panic",
         "very-long-abort2",
         "very-long-abort",

gix-url/tests/expand_path/mod.rs renamed to gix-url/tests/url/expand_path.rs

@@ -2,5 +2,7 @@ pub type Error = Box<dyn std::error::Error>;
 pub type Result = std::result::Result<(), Error>;
 
 mod access;
+mod baseline;
 mod expand_path;
+mod fuzzed;
 mod parse;