[clone] test ls-remote V2

Author: Byron

README.md

@@ -108,6 +108,7 @@ Please see _'Development Status'_ for a listing of all crates and their capabili
     * [x] ls-ref
       * [x] parse V1 refs as provided during handshake
       * [x] parse V2 refs
+    * [x] initialize and validate command arguments and features sanely
   * [ ] push
   * [ ] shallow clones
   * [ ] API documentation with examples

git-protocol/src/fetch/tests/command.rs

@@ -64,6 +64,17 @@ mod v1 {
                     &[],
                 );
             }
+
+            #[test]
+            #[should_panic]
+            fn unknown_argument() {
+                Command::LsRefs.validate_argument_prefixes_or_panic(
+                    git_transport::Protocol::V1,
+                    &capabilities("do-not-matter"),
+                    &[b"definitely-nothing-we-know".as_bstr().into()],
+                    &[],
+                );
+            }
         }
         mod initial_arguments {
             use crate::fetch::Command;
@@ -156,14 +167,25 @@ mod v2 {
             use bstr::ByteSlice;
 
             #[test]
-            fn ref_prefixes_always_be_used() {
+            fn ref_prefixes_can_always_be_used() {
                 Command::LsRefs.validate_argument_prefixes_or_panic(
                     git_transport::Protocol::V2,
                     &capabilities("something else", "do-not-matter"),
                     &[b"ref-prefix hello/".as_bstr().into()],
                     &[],
                 );
             }
+
+            #[test]
+            #[should_panic]
+            fn unknown_argument() {
+                Command::LsRefs.validate_argument_prefixes_or_panic(
+                    git_transport::Protocol::V1,
+                    &capabilities("other", "do-not-matter"),
+                    &[b"definitely-nothing-we-know".as_bstr().into()],
+                    &[],
+                );
+            }
         }
     }
 }

git-protocol/tests/fetch/mod.rs

@@ -1,3 +1,6 @@
+use crate::fixture_bytes;
+use bstr::ByteSlice;
+use git_object::owned;
 use git_protocol::fetch;
 use git_transport::client::Capabilities;
 
@@ -22,21 +25,37 @@ impl fetch::Delegate for LsRemoteDelegate {
     }
 }
 
+fn oid(hex_sha: &str) -> owned::Id {
+    owned::Id::from_40_bytes_in_hex(hex_sha.as_bytes()).expect("valid input")
+}
+
+fn transport<'a>(
+    out: &'a mut Vec<u8>,
+    path: &str,
+    version: git_transport::Protocol,
+) -> git_transport::client::git::Connection<std::io::Cursor<Vec<u8>>, &'a mut Vec<u8>> {
+    let response = fixture_bytes(path);
+    git_transport::client::git::Connection::new(
+        std::io::Cursor::new(response),
+        out,
+        version,
+        b"does/not/matter".as_bstr().to_owned(),
+        None::<(&str, _)>,
+        git_transport::client::git::ConnectMode::Process,
+    )
+}
+
 mod v1 {
-    use crate::{
-        fetch::{CloneDelegate, LsRemoteDelegate},
-        fixture_bytes,
-    };
-    use bstr::ByteSlice;
-    use git_object::owned;
+    use crate::fetch::{oid, transport, CloneDelegate, LsRemoteDelegate};
     use git_protocol::fetch;
+    use git_transport::Protocol;
 
     #[test]
     #[ignore]
     fn clone() -> crate::Result {
         let mut out = Vec::new();
         git_protocol::fetch(
-            transport(&mut out, "v1/clone.response"),
+            transport(&mut out, "v1/clone.response", Protocol::V1),
             &mut CloneDelegate,
             git_protocol::credentials::helper,
         )?;
@@ -48,7 +67,7 @@ mod v1 {
         let mut out = Vec::new();
         let mut delegate = LsRemoteDelegate::default();
         git_protocol::fetch(
-            transport(&mut out, "v1/clone.response"),
+            transport(&mut out, "v1/clone.response", Protocol::V1),
             &mut delegate,
             git_protocol::credentials::helper,
         )?;
@@ -73,23 +92,47 @@ mod v1 {
         );
         Ok(())
     }
+}
 
-    fn oid(hex_sha: &str) -> owned::Id {
-        owned::Id::from_40_bytes_in_hex(hex_sha.as_bytes()).expect("valid input")
-    }
+mod v2 {
+    use crate::fetch::{oid, transport, LsRemoteDelegate};
+    use bstr::ByteSlice;
+    use git_protocol::fetch;
+    use git_transport::Protocol;
+
+    #[test]
+    fn ls_remote() -> crate::Result {
+        let mut out = Vec::new();
+        let mut delegate = LsRemoteDelegate::default();
+        git_protocol::fetch(
+            transport(&mut out, "v2/clone.response", Protocol::V2),
+            &mut delegate,
+            git_protocol::credentials::helper,
+        )?;
 
-    fn transport<'a>(
-        out: &'a mut Vec<u8>,
-        path: &str,
-    ) -> git_transport::client::git::Connection<std::io::Cursor<Vec<u8>>, &'a mut Vec<u8>> {
-        let response = fixture_bytes(path);
-        git_transport::client::git::Connection::new(
-            std::io::Cursor::new(response),
-            out,
-            git_transport::Protocol::V1,
-            b"does/not/matter".as_bstr().to_owned(),
-            None::<(&str, _)>,
-            git_transport::client::git::ConnectMode::Process,
-        )
+        assert_eq!(
+            delegate.refs,
+            vec![
+                fetch::Ref::Symbolic {
+                    path: "HEAD".into(),
+                    object: oid("808e50d724f604f69ab93c6da2919c014667bedb"),
+                    target: "refs/heads/master".into()
+                },
+                fetch::Ref::Direct {
+                    path: "refs/heads/master".into(),
+                    object: oid("808e50d724f604f69ab93c6da2919c014667bedb")
+                }
+            ]
+        );
+        assert_eq!(
+            out.as_bstr(),
+            b"0014command=ls-refs
+001aagent=git/oxide-0.1.0
+0001000csymrefs
+0009peel
+00000000"
+                .as_bstr()
+        );
+        Ok(())
     }
 }