fix!: use dyn trait where possible.

This reduces compile time due to avoiding duplication.

Author: Byron

gix-date/src/time/format.rs

@@ -67,8 +67,8 @@ impl Time {
     ///
     /// Use the [`format_description`](https://time-rs.github.io/book/api/format-description.html) macro to create and
     /// validate formats at compile time, courtesy of the [`time`] crate.
-    pub fn format<'a>(&self, format: impl Into<Format<'a>>) -> String {
-        match format.into() {
+    pub fn format(&self, format: Format<'_>) -> String {
+        match format {
             Format::Custom(format) => self
                 .to_time()
                 .format(&format)

gix-date/src/time/write.rs

@@ -12,7 +12,7 @@ impl Time {
     }
 
     /// Serialize this instance to `out` in a format suitable for use in header fields of serialized git commits or tags.
-    pub fn write_to(&self, mut out: impl std::io::Write) -> std::io::Result<()> {
+    pub fn write_to(&self, out: &mut dyn std::io::Write) -> std::io::Result<()> {
         let mut itoa = itoa::Buffer::new();
         out.write_all(itoa.format(self.seconds).as_bytes())?;
         out.write_all(b" ")?;

gix-date/tests/time/format.rs

@@ -6,7 +6,7 @@ use time::macros::format_description;
 
 #[test]
 fn short() {
-    assert_eq!(time().format(format::SHORT), "1973-11-30");
+    assert_eq!(time().format(format::SHORT.into()), "1973-11-30");
 }
 
 #[test]
@@ -25,57 +25,66 @@ fn raw() {
 
 #[test]
 fn iso8601() {
-    assert_eq!(time().format(format::ISO8601), "1973-11-30 00:03:09 +0230");
+    assert_eq!(time().format(format::ISO8601.into()), "1973-11-30 00:03:09 +0230");
 }
 
 #[test]
 fn iso8601_strict() {
-    assert_eq!(time().format(format::ISO8601_STRICT), "1973-11-30T00:03:09+02:30");
+    assert_eq!(
+        time().format(format::ISO8601_STRICT.into()),
+        "1973-11-30T00:03:09+02:30"
+    );
 }
 
 #[test]
 fn rfc2822() {
-    assert_eq!(time().format(format::RFC2822), "Fri, 30 Nov 1973 00:03:09 +0230");
-    assert_eq!(time_dec1().format(format::RFC2822), "Sat, 01 Dec 1973 00:03:09 +0230");
+    assert_eq!(time().format(format::RFC2822.into()), "Fri, 30 Nov 1973 00:03:09 +0230");
+    assert_eq!(
+        time_dec1().format(format::RFC2822.into()),
+        "Sat, 01 Dec 1973 00:03:09 +0230"
+    );
 }
 
 #[test]
 fn git_rfc2822() {
-    assert_eq!(time().format(format::GIT_RFC2822), "Fri, 30 Nov 1973 00:03:09 +0230");
     assert_eq!(
-        time_dec1().format(format::GIT_RFC2822),
+        time().format(format::GIT_RFC2822.into()),
+        "Fri, 30 Nov 1973 00:03:09 +0230"
+    );
+    assert_eq!(
+        time_dec1().format(format::GIT_RFC2822.into()),
         "Sat, 1 Dec 1973 00:03:09 +0230"
     );
 }
 
 #[test]
 fn default() {
     assert_eq!(
-        time().format(gix_date::time::format::GITOXIDE),
+        time().format(gix_date::time::format::GITOXIDE.into()),
         "Fri Nov 30 1973 00:03:09 +0230"
     );
     assert_eq!(
-        time_dec1().format(gix_date::time::format::GITOXIDE),
+        time_dec1().format(gix_date::time::format::GITOXIDE.into()),
         "Sat Dec 01 1973 00:03:09 +0230"
     )
 }
 
 #[test]
 fn git_default() {
     assert_eq!(
-        time().format(gix_date::time::format::DEFAULT),
+        time().format(gix_date::time::format::DEFAULT.into()),
         "Fri Nov 30 00:03:09 1973 +0230"
     );
     assert_eq!(
-        time_dec1().format(gix_date::time::format::DEFAULT),
+        time_dec1().format(gix_date::time::format::DEFAULT.into()),
         "Sat Dec 1 00:03:09 1973 +0230"
     )
 }
 
 #[test]
 fn custom_compile_time() {
     assert_eq!(
-        time().format(format_description!("[year]-[month]-[day] [hour]:[minute]:[second]")),
+        time().format(format_description!("[year]-[month]-[day] [hour]:[minute]:[second]").into()),
         "1973-11-30 00:03:09",
     );
 }