fix: Assure ReadlineBufRead::readline_str() calls our implementation for Box<T: ReadlineBufRead> as well.

This fixes a bug where the HTTP implementation would incorrectly concatenate packetlines without newlines
as sent by the server for shallow info lines.

Author: Byron

gix-transport/src/client/async_io/bufread_ext.rs

@@ -94,7 +94,7 @@ impl<T: AsyncRead + Unpin> ReadlineBufRead for gix_packetline::read::WithSideban
         self.read_data_line().await
     }
     async fn readline_str(&mut self, line: &mut String) -> io::Result<usize> {
-        self.read_line(line).await
+        self.read_line_to_string(line).await
     }
 }
 
@@ -104,7 +104,7 @@ impl<'a, T: AsyncRead + Unpin> ReadlineBufRead for gix_packetline::read::WithSid
         self.read_data_line().await
     }
     async fn readline_str(&mut self, line: &mut String) -> io::Result<usize> {
-        self.read_line(line).await
+        self.read_line_to_string(line).await
     }
 }
 

gix-transport/src/client/blocking_io/bufread_ext.rs

@@ -1,4 +1,3 @@
-use std::io::BufRead;
 use std::{
     io,
     ops::{Deref, DerefMut},
@@ -58,7 +57,7 @@ impl<'a, T: ReadlineBufRead + ?Sized + 'a> ReadlineBufRead for Box<T> {
         ReadlineBufRead::readline(self.deref_mut())
     }
     fn readline_str(&mut self, line: &mut String) -> io::Result<usize> {
-        self.read_line(line)
+        ReadlineBufRead::readline_str(self.deref_mut(), line)
     }
 }
 
@@ -86,7 +85,7 @@ impl<T: io::Read> ReadlineBufRead for gix_packetline::read::WithSidebands<'_, T,
     }
 
     fn readline_str(&mut self, line: &mut String) -> io::Result<usize> {
-        self.read_line(line)
+        self.read_line_to_string(line)
     }
 }
 
@@ -96,7 +95,7 @@ impl<'a, T: io::Read> ReadlineBufRead for gix_packetline::read::WithSidebands<'a
     }
 
     fn readline_str(&mut self, line: &mut String) -> io::Result<usize> {
-        self.read_line(line)
+        self.read_line_to_string(line)
     }
 }