Skip to content

Commit 99238a7

Browse files
committed
Use a file with test-fixtures-windows expected failures
Instead of retrieving them from #1358. (See discussion in #1663.)
1 parent 067e7d2 commit 99238a7

File tree

2 files changed

+15
-18
lines changed

2 files changed

+15
-18
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -109,29 +109,12 @@ jobs:
109109
110110
Write-Output $actual_failures
111111
Set-Content -Path 'actual-failures.txt' -Value $actual_failures
112-
- name: Collect expected failures
113-
env:
114-
GH_TOKEN: ${{ github.token }}
115-
run: |
116-
$issue = 1358 # https://github.com/GitoxideLabs/gitoxide/issues/1358
117-
118-
$match_info = gh issue --repo GitoxideLabs/gitoxide view $issue --json body --jq .body |
119-
Out-String |
120-
Select-String -Pattern '(?s)```text\r?\n(.*?)```'
121-
122-
$expected_failures = $match_info.Matches.Groups[1].Value -split "`n" |
123-
Where-Object { ($_ -match '^\s*FAIL \[') -and ($_ -notmatch '\bperformance\b') } |
124-
ForEach-Object { $_ -replace '^\s*FAIL \[\s*\d+\.\d+s\]\s*', '' -replace '\s+$', '' } |
125-
Sort-Object
126-
127-
Write-Output $expected_failures
128-
Set-Content -Path 'expected-failures.txt' -Value $expected_failures
129112
- name: Compare expected and actual failures
130113
run: |
131114
# Fail on any differences, even unexpectedly passing tests, so they can be investigated.
132115
# (If the job is made blocking for PRs, it may make sense to make this less stringent.)
133116
git --no-pager diff --no-index --exit-code --unified=1000000 --color=always -- `
134-
expected-failures.txt actual-failures.txt
117+
etc/test-fixtures-windows-expected-failures-see-issue-1358.txt actual-failures.txt
135118
136119
test-32bit:
137120
runs-on: ubuntu-latest
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
gix-glob::glob pattern::matching::compare_baseline_with_ours
2+
gix-pathspec::pathspec parse::baseline
3+
gix-pathspec::pathspec parse::valid::glob_negations_are_always_literal
4+
gix-pathspec::pathspec parse::valid::whitespace_in_pathspec
5+
gix-pathspec::pathspec search::files
6+
gix-pathspec::pathspec search::prefixes_are_always_case_sensitive
7+
gix-submodule::submodule file::baseline::common_values_and_names_by_path
8+
gix-submodule::submodule file::is_active_platform::pathspecs_matter_even_if_they_do_not_match
9+
gix-submodule::submodule file::is_active_platform::submodules_with_active_config_are_considered_active_or_inactive
10+
gix-submodule::submodule file::is_active_platform::submodules_with_active_config_override_pathspecs
11+
gix-submodule::submodule file::is_active_platform::without_any_additional_settings_all_are_inactive_if_they_have_a_url
12+
gix-submodule::submodule file::is_active_platform::without_submodule_in_index
13+
gix::gix revision::spec::from_bytes::regex::find_youngest_matching_commit::regex_matches
14+
gix::gix revision::spec::from_bytes::regex::with_known_revision::contained_string_matches_in_unanchored_regex_and_disambiguates_automatically

0 commit comments

Comments
 (0)