Skip to content

Commit 9f845f1

Browse files
committed
Add expected snapshots for ambiguous username journey tests
The tests appear to work, at least partially, in that a test failure, of the kind expected due to gix-transport not yet checking for usernames that ssh clients can interpret as an option argument, is observed now that the current output has snapshots to compare to (the comparison fails, which at this point is intended). Not all tests ran, because of the runner script's fail-fast behavior and because the `receive` subcommand tests only run on CI. While I believe having these snapshots in now will make it eaiser to ensure nothing essential was forgotten, once ambiguous username handling is implemented, this does make these journey tests no longer strictly approval tests (since the snapshots incorporate foreknowledge of the intended behavior).
1 parent d63a19e commit 9f845f1

File tree

4 files changed

+4
-0
lines changed

4 files changed

+4
-0
lines changed

tests/snapshots/plumbing/no-repo/pack/clone/fail-ambiguous-username/explicit-ssh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Error: Username '-Fconfigfile' could be mistaken for a command-line argument

tests/snapshots/plumbing/no-repo/pack/clone/fail-ambiguous-username/implicit-ssh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Error: Username '-Fconfigfile' could be mistaken for a command-line argument
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Error: Username '-Fconfigfile' could be mistaken for a command-line argument
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Error: Username '-Fconfigfile' could be mistaken for a command-line argument

0 commit comments

Comments
 (0)