Skip to content

Commit bc0a1ea

Browse files
committed
Remove inactive username_password_not_available test
This is cleanup realted to #1644, which further complicated the attributes on the `#[ignore]`d `username_password_not_available` test with an empty that was build (but never run) whenever the `expectrl` tests of `gix-prompt` were not built. Instead of keeping its attributes more complicated and maintaining an expectation that they continue to be updated along with the `target_os` support for `expectrl`'s `ptyprocess` dependency, this removes that empty test. The purpose of the test case that this removes is unclear, and it may not have value anymore. It is unclear in part because actual interaction to provide a username and password is likely to work on some systems for which the related tests that use `expectrl` are not being built. But this empty test case might be read to say otherwise. See also the related discussion at: #1644 (review)
1 parent 35d4d9f commit bc0a1ea

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

gix-prompt/tests/prompt.rs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,4 @@ mod ask {
6363
p.expect("\" password with space \"").unwrap();
6464
p.expect(expectrl::Eof).unwrap();
6565
}
66-
67-
#[test]
68-
#[cfg(not(any(target_os = "linux", target_os = "freebsd", target_os = "macos")))]
69-
#[ignore]
70-
fn username_password_not_available() {}
7166
}

0 commit comments

Comments
 (0)