Skip to content

Commit e97c4f1

Browse files
committed
Make test-fixtures-windows required for PR auto-merge
Since #1663, the `test-fixtures-windows` CI job checks actual failures against a list of specific tests that are known to fail on Windows when `GIX_TEST_IGNORE_ARCHIVES=1`. It is therefore capable of providing useful information about new failures, or newly passing tests that should be removed from the list, if the job ever does fail. The job also seems not to fail. This is to say that while #1358 is not fixed, the `test-fixtures-windows` job has a very low rate of failure and, if it does fail, something new and interesting would be happening such that we would want to know about it and probably not immediately merge a PR that caused it without checking how and why that happened. This adds `test-fixtures-windows` to the list of jobs that are dependencies of a required check for branch protection based PR auto-merge.
1 parent f154ca0 commit e97c4f1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -406,7 +406,6 @@ jobs:
406406
# List all jobs that are intended NOT to block PR auto-merge here.
407407
EXPECTED_NONBLOCKING_JOBS: |-
408408
test-fast-arm
409-
test-fixtures-windows
410409
cargo-deny-advisories
411410
wasm
412411
tests-pass
@@ -443,6 +442,7 @@ jobs:
443442
- test
444443
- test-journey
445444
- test-fast
445+
- test-fixtures-windows
446446
- test-32bit
447447
- lint
448448
- cargo-deny

0 commit comments

Comments
 (0)