Skip to content

Commit 784115e

Browse files
newlingIanWood1
authored andcommitted
[mlir][vector] Remove remaining bitwidths from linearization patterns (llvm#138072)
In llvm#136581 the bitwidth logic was supposed to be completely removed from the linearization patterns. But it was left in a few places. This PR removes the remainders (they were default valued constructor arguments that were unused).
1 parent 40736ff commit 784115e

File tree

1 file changed

+8
-17
lines changed

1 file changed

+8
-17
lines changed

mlir/lib/Dialect/Vector/Transforms/VectorLinearize.cpp

Lines changed: 8 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
#include "mlir/Transforms/DialectConversion.h"
2222
#include "llvm/ADT/ArrayRef.h"
2323
#include <cstdint>
24-
#include <limits>
2524
#include <numeric>
2625
#include <optional>
2726

@@ -230,10 +229,8 @@ struct LinearizeVectorExtractStridedSlice final
230229
struct LinearizeVectorShuffle final
231230
: public OpConversionPattern<vector::ShuffleOp> {
232231
using OpConversionPattern::OpConversionPattern;
233-
LinearizeVectorShuffle(
234-
const TypeConverter &typeConverter, MLIRContext *context,
235-
unsigned targetVectBitWidth = std::numeric_limits<unsigned>::max(),
236-
PatternBenefit benefit = 1)
232+
LinearizeVectorShuffle(const TypeConverter &typeConverter,
233+
MLIRContext *context, PatternBenefit benefit = 1)
237234
: OpConversionPattern(typeConverter, context, benefit) {}
238235

239236
LogicalResult
@@ -290,10 +287,8 @@ struct LinearizeVectorShuffle final
290287
struct LinearizeVectorExtract final
291288
: public OpConversionPattern<vector::ExtractOp> {
292289
using OpConversionPattern::OpConversionPattern;
293-
LinearizeVectorExtract(
294-
const TypeConverter &typeConverter, MLIRContext *context,
295-
unsigned targetVectBitWidth = std::numeric_limits<unsigned>::max(),
296-
PatternBenefit benefit = 1)
290+
LinearizeVectorExtract(const TypeConverter &typeConverter,
291+
MLIRContext *context, PatternBenefit benefit = 1)
297292
: OpConversionPattern(typeConverter, context, benefit) {}
298293
LogicalResult
299294
matchAndRewrite(vector::ExtractOp extractOp, OpAdaptor adaptor,
@@ -339,10 +334,8 @@ struct LinearizeVectorExtract final
339334
struct LinearizeVectorInsert final
340335
: public OpConversionPattern<vector::InsertOp> {
341336
using OpConversionPattern::OpConversionPattern;
342-
LinearizeVectorInsert(
343-
const TypeConverter &typeConverter, MLIRContext *context,
344-
unsigned targetVectBitWidth = std::numeric_limits<unsigned>::max(),
345-
PatternBenefit benefit = 1)
337+
LinearizeVectorInsert(const TypeConverter &typeConverter,
338+
MLIRContext *context, PatternBenefit benefit = 1)
346339
: OpConversionPattern(typeConverter, context, benefit) {}
347340
LogicalResult
348341
matchAndRewrite(vector::InsertOp insertOp, OpAdaptor adaptor,
@@ -408,10 +401,8 @@ struct LinearizeVectorInsert final
408401
struct LinearizeVectorBitCast final
409402
: public OpConversionPattern<vector::BitCastOp> {
410403
using OpConversionPattern::OpConversionPattern;
411-
LinearizeVectorBitCast(
412-
const TypeConverter &typeConverter, MLIRContext *context,
413-
unsigned targetVectBitWidth = std::numeric_limits<unsigned>::max(),
414-
PatternBenefit benefit = 1)
404+
LinearizeVectorBitCast(const TypeConverter &typeConverter,
405+
MLIRContext *context, PatternBenefit benefit = 1)
415406
: OpConversionPattern(typeConverter, context, benefit) {}
416407
LogicalResult
417408
matchAndRewrite(vector::BitCastOp castOp, OpAdaptor adaptor,

0 commit comments

Comments
 (0)