Skip to content

Commit bc1bd78

Browse files
committed
[NFC] Revise descriptions of DXIL module flags
1 parent 812e02a commit bc1bd78

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

llvm/include/llvm/BinaryFormat/DXContainerConstants.def

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ CONTAINER_PART(PSG1)
1717
// SHADER_FEATURE_FLAG(bit offset for the shader info flag, bit offset for DXIL module flag, name, description.
1818

1919
SHADER_FEATURE_FLAG(0, 2, Doubles, "Double-precision floating point")
20-
SHADER_FEATURE_FLAG(1, 17, ComputeShadersPlusRawAndStructuredBuffers, "Raw and Structured buffers")
20+
SHADER_FEATURE_FLAG(1, 17, ComputeShadersPlusRawAndStructuredBuffers, "CS4 raw and structured buffers")
2121
SHADER_FEATURE_FLAG(2, 16, UAVsAtEveryStage, "UAVs at every shader stage")
2222
SHADER_FEATURE_FLAG(3, 15, Max64UAVs, "64 UAV slots")
2323
SHADER_FEATURE_FLAG(4, -1, MinimumPrecision, "Minimum-precision data types")
@@ -76,13 +76,13 @@ ROOT_ELEMENT_FLAG(11, SamplerHeapDirectlyIndexed)
7676
#ifdef DXIL_MODULE_FLAG
7777

7878
// Only save DXIL module flags which not map to feature flags here.
79-
DXIL_MODULE_FLAG( 0, DisableOptimizations, "D3D11_1_SB_GLOBAL_FLAG_SKIP_OPTIMIZATION")
80-
DXIL_MODULE_FLAG( 1, DisableMathRefactoring, "D3D10_SB_GLOBAL_FLAG_REFACTORING_ALLOWED")
81-
DXIL_MODULE_FLAG( 3, ForceEarlyDepthStencil, "D3D11_SB_GLOBAL_FLAG_FORCE_EARLY_DEPTH_STENCIL")
82-
DXIL_MODULE_FLAG( 4, EnableRawAndStructuredBuffers, "Raw and Structured buffers")
83-
DXIL_MODULE_FLAG( 5, LowPrecisionPresent, "D3D11_1_SB_GLOBAL_FLAG_ENABLE_MINIMUM_PRECISION")
84-
DXIL_MODULE_FLAG( 8, AllResourcesBound, "D3D12_SB_GLOBAL_FLAG_ALL_RESOURCES_BOUND")
85-
DXIL_MODULE_FLAG(23, UseNativeLowPrecision, "Native 16bit types enabled")
79+
DXIL_MODULE_FLAG( 0, DisableOptimizations, "Disable shader optimizations")
80+
DXIL_MODULE_FLAG( 1, DisableMathRefactoring, "Disable math refactoring")
81+
DXIL_MODULE_FLAG( 3, ForceEarlyDepthStencil, "Force early depth-stencil test")
82+
DXIL_MODULE_FLAG( 4, EnableRawAndStructuredBuffers, "Raw and structured buffers")
83+
DXIL_MODULE_FLAG( 5, LowPrecisionPresent, "Low-precision data types")
84+
DXIL_MODULE_FLAG( 8, AllResourcesBound, "All resources bound")
85+
DXIL_MODULE_FLAG(23, UseNativeLowPrecision, "Native 16-bit types enabled")
8686
DXIL_MODULE_FLAG(33, ResMayNotAlias, "Any UAV may not alias any other UAV")
8787

8888
#undef DXIL_MODULE_FLAG

llvm/test/CodeGen/DirectX/ShaderFlags/disable-opt-cs.ll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
; CHECK-NEXT: ; Shader Flags Value: 0x00000001
66

77
; CHECK: ; Note: extra DXIL module flags:
8-
; CHECK-NEXT: ; D3D11_1_SB_GLOBAL_FLAG_SKIP_OPTIMIZATION
8+
; CHECK-NEXT: ; Disable shader optimizations
99

1010
; CHECK: ; Shader Flags for Module Functions
1111
; CHECK: ; Function main : 0x00000000

llvm/test/CodeGen/DirectX/ShaderFlags/disable-opt-lib.ll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
; CHECK-NEXT: ; Shader Flags Value: 0x00000001
66

77
; CHECK: ; Note: extra DXIL module flags:
8-
; CHECK-NEXT: ; D3D11_1_SB_GLOBAL_FLAG_SKIP_OPTIMIZATION
8+
; CHECK-NEXT: ; Disable shader optimizations
99

1010
; CHECK: ; Shader Flags for Module Functions
1111
; CHECK: ; Function main : 0x00000000

llvm/test/CodeGen/DirectX/ShaderFlags/low-precision.ll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ target triple = "dxil-pc-shadermodel6.7-library"
88
;CHECK-NEXT: ;
99
;CHECK-NEXT: ; Note: shader requires additional functionality:
1010
;CHECK-NEXT: ; Note: extra DXIL module flags:
11-
;CHECK-NEXT: ; D3D11_1_SB_GLOBAL_FLAG_ENABLE_MINIMUM_PRECISION
11+
;CHECK-NEXT: ; Low-precision data types
1212
;CHECK-NEXT: ;
1313
;CHECK-NEXT: ; Shader Flags for Module Functions
1414

llvm/test/CodeGen/DirectX/ShaderFlags/raw-and-structured-buffers.ll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ target triple = "dxil-pc-shadermodel6.7-library"
99
; CHECK-NEXT: Shader Flags Value: 0x00000010
1010

1111
; CHECK: Note: shader requires additional functionality:
12-
; CHECK: Raw and Structured buffers
12+
; CHECK: Raw and structured buffers
1313

1414
; CHECK: Function rawbuf : 0x00000010
1515
define float @rawbuf() "hlsl.export" {

0 commit comments

Comments
 (0)