Skip to content

Move CC votes mempool check #5022

New issue
New issue
Open
#5091
Open
Move CC votes mempool check#5022
#5091
Assignees
aniketd
Labels
conwayintra-era-hardforkA task that requires an intra-era hard fork
@lehins

Description

@lehins
lehins
opened on May 5, 2025

There is a check that we added to memepool, since we didn't get it in time for the previous hardfork:

cardano-ledger/eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Mempool.hs

Lines 120 to 135 in d90eb4d

-- Disallow votes by unelected committee members
let
authorizedElectedHotCreds = authorizedElectedHotCommitteeCredentials ledgerState
collectUnelectedCommitteeVotes !unelectedHotCreds voter _ =
case voter of
CommitteeVoter hotCred
| hotCred `Set.notMember` authorizedElectedHotCreds ->
Set.insert hotCred unelectedHotCreds
_ -> unelectedHotCreds
unelectedCommitteeVoters =
Map.foldlWithKey' collectUnelectedCommitteeVotes Set.empty $
unVotingProcedures (tx ^. bodyTxL . votingProceduresTxBodyL)
addPrefix =
("Unelected committee members are not allowed to cast votes: " <>)
failOnNonEmpty unelectedCommitteeVoters $
ConwayMempoolFailure . addPrefix . T.pack . show . NE.toList

We need to add the same check into the GOV rule and enable it for protocol version 11
and also disable the one in MEMPOOL starting with the same protocol version. Check in the MEMEPOOL rule can later be removed once we are in protocol version 11, thus a follow up ticket will need to be created whenever this one is resolved.

Metadata

Metadata

Assignees

Labels

conwayintra-era-hardforkA task that requires an intra-era hard fork

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions