Skip to content

Commit a629039

Browse files
authored
Split style checks into separate workflow (#542)
Currently, style checks are integrated with functional tests in the same workflow. This meant that any style issues cause the entire test suite to fail. This pull request: - Creates a new workflow file `.github/workflows/style.yml` for style checks - Removes style check step from the test workflow The benefit of making this change is that it becomes easier to identify whether issues are related to code style or functionality.
2 parents 1eb04bd + 7e6dd91 commit a629039

File tree

2 files changed

+21
-2
lines changed

2 files changed

+21
-2
lines changed

.github/workflows/style.yml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
name: Style Check
2+
3+
on:
4+
push:
5+
branches:
6+
- main
7+
pull_request:
8+
branches:
9+
- main
10+
11+
jobs:
12+
style:
13+
name: Style Check
14+
runs-on: ubuntu-latest
15+
steps:
16+
- uses: actions/checkout@v4
17+
- uses: astral-sh/setup-uv@v3
18+
- name: Install Python
19+
run: uv python install 3.11
20+
- name: Check style
21+
run: uv run --extra dev black --check --diff .

.github/workflows/test.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@ jobs:
3535
run: sudo apt-get install -y libsndfile1
3636
- name: Run tests
3737
run: uv run --with ${{ matrix.numpy }} --extra dev pytest
38-
- name: Check style
39-
run: uv run --extra dev black --check --diff .
4038

4139
test-deb11-i386:
4240
name: Python 3.7 on Debian 11 i386

0 commit comments

Comments
 (0)