Skip to content

Commit 1bcfbff

Browse files
committed
Rename Mangler linkage enums to something less gross.
llvm-svn: 76456
1 parent 8ff0f8d commit 1bcfbff

File tree

4 files changed

+19
-23
lines changed

4 files changed

+19
-23
lines changed

llvm/include/llvm/Support/Mangler.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ class GlobalValue;
2727
class Mangler {
2828
public:
2929
enum ManglerPrefixTy {
30-
DefaultPrefixTy, ///< Emit default string before each symbol.
31-
PrivatePrefixTy, ///< Emit "private" prefix before each symbol.
32-
LinkerPrivatePrefixTy ///< Emit "linker private" prefix before each symbol.
30+
Default, ///< Emit default string before each symbol.
31+
Private, ///< Emit "private" prefix before each symbol.
32+
LinkerPrivate ///< Emit "linker private" prefix before each symbol.
3333
};
3434

3535
private:
@@ -103,7 +103,7 @@ class Mangler {
103103
/// from getValueName.
104104
///
105105
std::string makeNameProper(const std::string &x,
106-
ManglerPrefixTy PrefixTy = DefaultPrefixTy);
106+
ManglerPrefixTy PrefixTy = Mangler::Default);
107107
};
108108

109109
} // End llvm namespace

llvm/lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -93,14 +93,10 @@ namespace {
9393
void Init(const std::string &GV, Mangler *Mang) {
9494
// Already initialized.
9595
if (!Stub.empty()) return;
96-
Stub = Mang->makeNameProper(GV + "$stub",
97-
Mangler::PrivatePrefixTy);
98-
LazyPtr = Mang->makeNameProper(GV + "$lazy_ptr",
99-
Mangler::PrivatePrefixTy);
100-
SLP = Mang->makeNameProper(GV + "$slp",
101-
Mangler::PrivatePrefixTy);
102-
SCV = Mang->makeNameProper(GV + "$scv",
103-
Mangler::PrivatePrefixTy);
96+
Stub = Mang->makeNameProper(GV + "$stub", Mangler::Private);
97+
LazyPtr = Mang->makeNameProper(GV + "$lazy_ptr", Mangler::Private);
98+
SLP = Mang->makeNameProper(GV + "$slp", Mangler::Private);
99+
SCV = Mang->makeNameProper(GV + "$scv", Mangler::Private);
104100
}
105101
};
106102

llvm/lib/Target/PowerPC/AsmPrinter/PPCAsmPrinter.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,11 @@ namespace {
7171
// Already initialized.
7272
if (!Stub.empty()) return;
7373
Stub = Mang->makeNameProper(GV + "$stub",
74-
Mangler::PrivatePrefixTy);
74+
Mangler::Private);
7575
LazyPtr = Mang->makeNameProper(GV + "$lazy_ptr",
76-
Mangler::PrivatePrefixTy);
76+
Mangler::Private);
7777
AnonSymbol = Mang->makeNameProper(GV + "$stub$tmp",
78-
Mangler::PrivatePrefixTy);
78+
Mangler::Private);
7979
}
8080
};
8181

llvm/lib/VMCore/Mangler.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,9 @@ std::string Mangler::makeNameProper(const std::string &X,
6060
if (NeedPrefix) {
6161
Result = Prefix + Result;
6262

63-
if (PrefixTy == PrivatePrefixTy)
63+
if (PrefixTy == Mangler::Private)
6464
Result = PrivatePrefix + Result;
65-
else if (PrefixTy == LinkerPrivatePrefixTy)
65+
else if (PrefixTy == Mangler::LinkerPrivate)
6666
Result = LinkerPrivatePrefix + Result;
6767
}
6868

@@ -98,9 +98,9 @@ std::string Mangler::makeNameProper(const std::string &X,
9898

9999
Result = Prefix + X;
100100

101-
if (PrefixTy == PrivatePrefixTy)
101+
if (PrefixTy == Mangler::Private)
102102
Result = PrivatePrefix + Result;
103-
else if (PrefixTy == LinkerPrivatePrefixTy)
103+
else if (PrefixTy == Mangler::LinkerPrivate)
104104
Result = LinkerPrivatePrefix + Result;
105105

106106
return Result;
@@ -121,9 +121,9 @@ std::string Mangler::makeNameProper(const std::string &X,
121121
if (NeedPrefix) {
122122
Result = Prefix + Result;
123123

124-
if (PrefixTy == PrivatePrefixTy)
124+
if (PrefixTy == Mangler::Private)
125125
Result = PrivatePrefix + Result;
126-
else if (PrefixTy == LinkerPrivatePrefixTy)
126+
else if (PrefixTy == Mangler::LinkerPrivate)
127127
Result = LinkerPrivatePrefix + Result;
128128
}
129129

@@ -142,8 +142,8 @@ std::string Mangler::getMangledName(const GlobalValue *GV, const char *Suffix,
142142
"Intrinsic functions cannot be mangled by Mangler");
143143

144144
ManglerPrefixTy PrefixTy =
145-
(GV->hasPrivateLinkage() || ForcePrivate) ? PrivatePrefixTy :
146-
GV->hasLinkerPrivateLinkage() ? LinkerPrivatePrefixTy : DefaultPrefixTy;
145+
(GV->hasPrivateLinkage() || ForcePrivate) ? Mangler::Private :
146+
GV->hasLinkerPrivateLinkage() ? Mangler::LinkerPrivate : Mangler::Default;
147147

148148
if (GV->hasName())
149149
return makeNameProper(GV->getName() + Suffix, PrefixTy);

0 commit comments

Comments
 (0)