Ensure InAppMessagesManager will capture/send impressions even if there is no IAM lifecycle listener set by the app. (#1980)

brismithers · web-flow · commit 2072eac55929 · 2024-02-02T17:37:37.000-05:00
* Ensure InAppMessagesManager will capture/send impressions even if there is no IAM lifecycle listener set by the app.

* Flip the logic of if/else check
diff --git a/OneSignalSDK/onesignal/in-app-messages/src/main/java/com/onesignal/inAppMessages/internal/InAppMessagesManager.kt b/OneSignalSDK/onesignal/in-app-messages/src/main/java/com/onesignal/inAppMessages/internal/InAppMessagesManager.kt
@@ -526,11 +526,12 @@ internal class InAppMessagesManager(
     }
 
     override fun onMessageWasDisplayed(message: InAppMessage) {
-        if (!lifecycleCallback.hasSubscribers) {
+        if (lifecycleCallback.hasSubscribers) {
+            lifecycleCallback.fireOnMain { it.onDidDisplay(InAppMessageLifecycleEvent(message)) }
+        }
+        else {
             Logging.verbose("InAppMessagesManager.onMessageWasDisplayed: inAppMessageLifecycleHandler is null")
-            return
         }
-        lifecycleCallback.fireOnMain { it.onDidDisplay(InAppMessageLifecycleEvent(message)) }
 
         if (message.isPreview) {
             return

Original file line number	Diff line number	Diff line change
`@@ -526,11 +526,12 @@ internal class InAppMessagesManager(`
`526`	`526`	`}`
`527`	`527`
`528`	`528`	`override fun onMessageWasDisplayed(message: InAppMessage) {`
`529`		`- if (!lifecycleCallback.hasSubscribers) {`
	`529`	`+ if (lifecycleCallback.hasSubscribers) {`
	`530`	`+ lifecycleCallback.fireOnMain { it.onDidDisplay(InAppMessageLifecycleEvent(message)) }`
	`531`	`+ }`
	`532`	`+ else {`
`530`	`533`	`Logging.verbose("InAppMessagesManager.onMessageWasDisplayed: inAppMessageLifecycleHandler is null")`
`531`		`- return`
`532`	`534`	`}`
`533`		`- lifecycleCallback.fireOnMain { it.onDidDisplay(InAppMessageLifecycleEvent(message)) }`
`534`	`535`
`535`	`536`	`if (message.isPreview) {`
`536`	`537`	`return`