Skip to content

Firebase authentication provider is implemented #3174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 19 additions & 20 deletions src/authDataManager/firebase.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,38 +5,37 @@ var admin = require("firebase-admin");

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty line

var firebaseServiceAccount = process.env.FIREBASE_SERVICE_ACCOUNT;
if (firebaseServiceAccount != null) {
admin.initializeApp({
credential: admin.credential.cert(require(firebaseServiceAccount))
});
admin.initializeApp({
credential: admin.credential.cert(require(firebaseServiceAccount))
});
}


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty line

// Returns a promise that fulfills iff this user id is valid.
function validateAuthData(authData) {
if (firebaseServiceAccount == null || firebaseServiceAccount == "") {
throw new Parse.Error(Parse.Error.FILE_READ_ERROR, "Firebase service account file not exists");
}

return admin.auth().verifyIdToken(authData.access_token)
.then(function (decodedToken) {
if (decodedToken == null || decodedToken.uid == null || decodedToken.uid == "") {
throw new Parse.Error(Parse.Error.OBJECT_NOT_FOUND, "Firebase user not found");
}
return;
}).catch(function (error) {
console.log(error)
throw new Parse.Error(Parse.Error.OBJECT_NOT_FOUND, error.message);
});
if (firebaseServiceAccount == null || firebaseServiceAccount == "") {
throw new Parse.Error(Parse.Error.FILE_READ_ERROR, "Firebase service account file not exists");
}

return admin.auth().verifyIdToken(authData.access_token)
.then(function (decodedToken) {
if (decodedToken == null || decodedToken.uid == null || decodedToken.uid == "") {
throw new Parse.Error(Parse.Error.OBJECT_NOT_FOUND, "Firebase user not found");
}
return;
}).catch(function (error) {
throw new Parse.Error(Parse.Error.OBJECT_NOT_FOUND, error.message);
});

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty line

}

// Returns a promise that fulfills if this app id is valid.
function validateAppId() {
return Promise.resolve();
return Promise.resolve();
}


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty line

module.exports = {
validateAppId,
validateAuthData
validateAppId,
validateAuthData
};
3 changes: 2 additions & 1 deletion src/authDataManager/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ let wechat = require("./wechat");
let weibo = require("./weibo");
let firebase = require("./firebase");

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty line


let anonymous = {
validateAuthData: () => {
return Promise.resolve();
Expand All @@ -41,7 +42,7 @@ let providers = {
qq,
wechat,
weibo,
firebase
firebase
}

module.exports = function(oauthOptions = {}, enableAnonymousUsers = true) {
Expand Down