chore: survey 10kb win (#1921)

Author: lucasheriques

src/extensions/surveys/surveys-extension-utils.tsx

@@ -9,7 +9,7 @@ import {
     SurveySchedule,
 } from '../../posthog-surveys-types'
 import { document as _document, window as _window, userAgent } from '../../utils/globals'
-import { SURVEY_LOGGER as logger } from '../../utils/survey-utils'
+import { SURVEY_LOGGER as logger, SURVEY_SEEN_PREFIX } from '../../utils/survey-utils'
 import { prepareStylesheet } from '../utils/stylesheet-loader'
 
 import { SurveyMatchType } from '../../posthog-surveys-types'
@@ -18,7 +18,6 @@ import { detectDeviceType } from '../../utils/user-agent-utils'
 // We cast the types here which is dangerous but protected by the top level generateSurveys call
 const window = _window as Window & typeof globalThis
 const document = _document as Document
-const SurveySeenPrefix = 'seenSurvey_'
 
 export const SURVEY_DEFAULT_Z_INDEX = 2147483647
 
@@ -700,26 +699,14 @@ export const getSurveySeen = (survey: Survey): boolean => {
 }
 
 export const getSurveySeenKey = (survey: Survey): string => {
-    let surveySeenKey = `${SurveySeenPrefix}${survey.id}`
+    let surveySeenKey = `${SURVEY_SEEN_PREFIX}${survey.id}`
     if (survey.current_iteration && survey.current_iteration > 0) {
-        surveySeenKey = `${SurveySeenPrefix}${survey.id}_${survey.current_iteration}`
+        surveySeenKey = `${SURVEY_SEEN_PREFIX}${survey.id}_${survey.current_iteration}`
     }
 
     return surveySeenKey
 }
 
-export const getSurveySeenStorageKeys = (): string[] => {
-    const surveyKeys = []
-    for (let i = 0; i < localStorage.length; i++) {
-        const key = localStorage.key(i)
-        if (key?.startsWith(SurveySeenPrefix)) {
-            surveyKeys.push(key)
-        }
-    }
-
-    return surveyKeys
-}
-
 const getSurveyInteractionProperty = (survey: Survey, action: string): string => {
     let surveyProperty = `$survey_${action}/${survey.id}`
     if (survey.current_iteration && survey.current_iteration > 0) {

src/posthog-surveys-types.ts

@@ -199,6 +199,7 @@ export interface Survey {
     current_iteration: number | null
     current_iteration_start_date: string | null
     schedule?: SurveySchedule | null
+    enable_partial_responses?: boolean | null
 }
 
 export interface SurveyActionType {

src/posthog-surveys.ts

@@ -1,6 +1,5 @@
 import { SURVEYS } from './constants'
 import { SurveyManager } from './extensions/surveys'
-import { getSurveySeenStorageKeys } from './extensions/surveys/surveys-extension-utils'
 import { PostHog } from './posthog-core'
 import { Survey, SurveyCallback, SurveyRenderReason } from './posthog-surveys-types'
 import { RemoteConfig } from './types'
@@ -11,6 +10,7 @@ import {
     doesSurveyActivateByEvent,
     isSurveyRunning,
     SURVEY_LOGGER as logger,
+    SURVEY_SEEN_PREFIX,
 } from './utils/survey-utils'
 import { isArray, isNullish } from './utils/type-utils'
 
@@ -44,7 +44,14 @@ export class PostHogSurveys {
 
     reset(): void {
         localStorage.removeItem('lastSeenSurveyDate')
-        const surveyKeys = getSurveySeenStorageKeys()
+        const surveyKeys = []
+        for (let i = 0; i < localStorage.length; i++) {
+            const key = localStorage.key(i)
+            if (key?.startsWith(SURVEY_SEEN_PREFIX)) {
+                surveyKeys.push(key)
+            }
+        }
+
         surveyKeys.forEach((key) => localStorage.removeItem(key))
     }
 

src/utils/survey-utils.ts

@@ -14,3 +14,5 @@ export function doesSurveyActivateByEvent(survey: Pick<Survey, 'conditions'>): b
 export function doesSurveyActivateByAction(survey: Pick<Survey, 'conditions'>): boolean {
     return !!survey.conditions?.actions?.values?.length
 }
+
+export const SURVEY_SEEN_PREFIX = 'seenSurvey_'