Handle unknown scoreboard objectives (#3191)

* Handle unknown scoreboard objectives

* Fix lint

* Throw as error instead of string

* Use Object.hasOwn instead of in operator

---------

Co-authored-by: Frej Alexander Nielsen <[email protected]>
Co-authored-by: Romain Beaumont <[email protected]>

Author: 3 people

lib/plugins/scoreboard.js

@@ -19,6 +19,10 @@ function inject (bot) {
     }
 
     if (packet.action === 2) {
+      if (!Object.hasOwn(scoreboards, packet.name)) {
+        bot.emit('error', new Error(`Received update for unknown objective ${packet.name}`))
+        return
+      }
       scoreboards[packet.name].setTitle(packet.displayText)
       bot.emit('scoreboardTitleChanged', scoreboards[packet.name])
     }