Revert "[NFC] Remove checking pointee type for byval/preallocated type"

slackito · slackito · commit 9ac7388e3dd5 · 2021-06-17T12:29:23.000-07:00
This reverts commit 738abfd.
diff --git a/llvm/include/llvm/IR/InstrTypes.h b/llvm/include/llvm/IR/InstrTypes.h
@@ -1729,13 +1729,13 @@ class CallBase : public Instruction {
   /// Extract the byval type for a call or parameter.
   Type *getParamByValType(unsigned ArgNo) const {
     Type *Ty = Attrs.getParamByValType(ArgNo);
-    return Ty;
+    return Ty ? Ty : getArgOperand(ArgNo)->getType()->getPointerElementType();
   }
 
   /// Extract the preallocated type for a call or parameter.
   Type *getParamPreallocatedType(unsigned ArgNo) const {
     Type *Ty = Attrs.getParamPreallocatedType(ArgNo);
-    return Ty;
+    return Ty ? Ty : getArgOperand(ArgNo)->getType()->getPointerElementType();
   }
 
   /// Extract the number of dereferenceable bytes for a call or

Original file line number	Diff line number	Diff line change
`@@ -1729,13 +1729,13 @@ class CallBase : public Instruction {`
`1729`	`1729`	`/// Extract the byval type for a call or parameter.`
`1730`	`1730`	`Type *getParamByValType(unsigned ArgNo) const {`
`1731`	`1731`	`Type *Ty = Attrs.getParamByValType(ArgNo);`
`1732`		`- return Ty;`
	`1732`	`+ return Ty ? Ty : getArgOperand(ArgNo)->getType()->getPointerElementType();`
`1733`	`1733`	`}`
`1734`	`1734`
`1735`	`1735`	`/// Extract the preallocated type for a call or parameter.`
`1736`	`1736`	`Type *getParamPreallocatedType(unsigned ArgNo) const {`
`1737`	`1737`	`Type *Ty = Attrs.getParamPreallocatedType(ArgNo);`
`1738`		`- return Ty;`
	`1738`	`+ return Ty ? Ty : getArgOperand(ArgNo)->getType()->getPointerElementType();`
`1739`	`1739`	`}`
`1740`	`1740`
`1741`	`1741`	`/// Extract the number of dereferenceable bytes for a call or`