Skip to content

Commit 1d2eced

Browse files
authored
[llvm][docs] Update the Python version requirement to 3.8.0 for lit testing on Windows with substitute (virtual) drives. (llvm#81663)
Following the changes made for: - https://reviews.llvm.org/D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations in commit: - 05d613e Python 3.8.0 or newer is now required by at least the following tests when they are run on Windows from a substitute (virtual) drive. A substitute drive is often used as a workaround for `MAX_PATH` limitations on Windows. These tests are impacted because they use the lit `%{?:real}` path expansion syntax to expand symbolic links and substitute drives. This path expansion is implemented with Python's `os.path.realpath()` function which changed behavior in Python 3.8.0 with regard to expansion of substitute drives. The changes mentioned above rely on the newer Python behavior. - `clang/test/Lexer/case-insensitive-include-absolute.c` - `clang/test/Lexer/case-insensitive-include-win.c` This change updates the LLVM Getting Started guide to note this newer Python version dependency for this relatively niche case. Python 3.6.0 remains the minimum required Python version otherwise.
1 parent 45732b6 commit 1d2eced

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

llvm/docs/GettingStarted.rst

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -295,8 +295,9 @@ Package Version Notes
295295

296296
.. note::
297297

298-
#. Only needed if you want to run the automated test suite in the
299-
``llvm/test`` directory.
298+
#. Only needed if you want to run the automated test suite. Python 3.8.0
299+
or later is needed on Windows if a substitute (virtual) drive is used
300+
to access LLVM source code due to ``MAX_PATH`` limitations.
300301
#. Optional, adds compression / uncompression capabilities to selected LLVM
301302
tools.
302303
#. Optional, you can use any other build tool supported by CMake.

0 commit comments

Comments
 (0)