fix(filter): remove unsupported Vue.filter #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robo-Rin
force-pushed
the
fix/vue3-replace-filter-with-utility-function
branch
from
32fd587 to
b92dc9d
Compare
Umi8Umi
reviewed
Jul 12, 2023
tests/plugin.test.js
Outdated
| describe('Plugin tests', () => { | ||
| describe('useFacade', () => { | ||
| const ComponentMock = { | ||
| template: '<div id="maskedText">{{ useFacade(input, facadeConfig) }}</div>', |
There was a problem hiding this comment.
maybe good to edit the readme section for filters to show this new syntax as well
there is also the filter.md which is shown in the styleguide for the intput facade which would be nice to update with this vue3 compatible syntax
Umi8Umi
reviewed
Jul 12, 2023
src/plugin.js
Outdated
| * | ||
| * @param {String} value the value to apply the filter to | ||
| * @param {*} config the masking config | ||
| * @returns {string} the masked value as returned by the masker function | ||
| */ | ||
| function filter(value, config) { | ||
| function useFacade(value, config) { |
RonaldJerez
reviewed
Jul 12, 2023
src/plugin.js
Outdated
| * | ||
| * @param {String} value the value to apply the filter to | ||
| * @param {*} config the masking config | ||
| * @returns {string} the masked value as returned by the masker function | ||
| */ | ||
| function filter(value, config) { | ||
| function useFacade(value, config) { |
There was a problem hiding this comment.
Since the filters are no longer supported then we should just remove this function and anyone who needs it can just use the masker function which is already been exported. This was just a wrapper around that function for syntax sugar in vue2.
Vue 3 doesn't support Vue.filter anymore but we can use the masker directly instead. closes RonaldJerez#44
Robo-Rin
force-pushed
the
fix/vue3-replace-filter-with-utility-function
branch
from
b92dc9d to
344ff9d
Compare
Robo-Rin
changed the title
|
🎉 This PR is included in version 3.0.0-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Robo-Rin
added a commit
to Robo-Rin/vue-input-facade
that referenced
this pull request
Jan 4, 2024
Vue 3 doesn't support Vue.filter anymore but we can use the masker directly instead. closes RonaldJerez#44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Vue 3 upgrade gives errors due to the deprecated
Vue.filter. This PR fixes this issue by removing the filter altogether. As mentioned by Ronald further down we can use the already exportedmaskerdirectly instead.For example:
Note: Not marking this as a breaking change as the existing beta branch was already broken for Vue 3.
Checklist