Skip to content

Commit 1c4a428

Browse files
committed
Revert "Optimize?"
This reverts commit c4516a1.
1 parent d8d522b commit 1c4a428

File tree

2 files changed

+8
-32
lines changed

2 files changed

+8
-32
lines changed

Zend/zend_vm_def.h

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4160,10 +4160,7 @@ ZEND_VM_HOT_HANDLER(131, ZEND_DO_FCALL_BY_NAME, ANY, ANY, SPEC(RETVAL,OBSERVER))
41604160
if ((fbc->common.fn_flags & ZEND_ACC_DEPRECATED) != 0) {
41614161
zend_deprecated_function(fbc);
41624162
}
4163-
if (
4164-
UNEXPECTED(!RETURN_VALUE_USED(opline) && (fbc->common.fn_flags & ZEND_ACC_NODISCARD) != 0)
4165-
&& EG(exception) == NULL
4166-
) {
4163+
if (EG(exception) == NULL && (fbc->common.fn_flags & ZEND_ACC_NODISCARD) != 0 && !RETURN_VALUE_USED(opline)) {
41674164
zend_nodiscard_function("(B)", fbc);
41684165
}
41694166
if (UNEXPECTED(EG(exception) != NULL)) {
@@ -4272,10 +4269,7 @@ ZEND_VM_HOT_HANDLER(60, ZEND_DO_FCALL, ANY, ANY, SPEC(RETVAL,OBSERVER))
42724269
if ((fbc->common.fn_flags & ZEND_ACC_DEPRECATED) != 0) {
42734270
zend_deprecated_function(fbc);
42744271
}
4275-
if (
4276-
UNEXPECTED(!RETURN_VALUE_USED(opline) && (fbc->common.fn_flags & ZEND_ACC_NODISCARD) != 0)
4277-
&& EG(exception) == NULL
4278-
) {
4272+
if (EG(exception) == NULL && (fbc->common.fn_flags & ZEND_ACC_NODISCARD) != 0 && !RETURN_VALUE_USED(opline)) {
42794273
zend_nodiscard_function("(A)", fbc);
42804274
}
42814275
if (UNEXPECTED(EG(exception) != NULL)) {

Zend/zend_vm_execute.h

Lines changed: 6 additions & 24 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)