Remove some false positives from basic auth

XIANJUN ZHU · Xianjun Zhu · commit e3441a772c24 · 2019-01-31T21:14:15.000-05:00
Exclude single and double quotes in matching
diff --git a/detect_secrets/plugins/basic_auth.py b/detect_secrets/plugins/basic_auth.py
@@ -5,7 +5,7 @@
 from .base import RegexBasedDetector
 
 
-SPECIAL_URL_CHARACTERS = ':/?#[]@'
+SPECIAL_URL_CHARACTERS = ':/?#[]@"\''
 
 
 class BasicAuthDetector(RegexBasedDetector):
diff --git a/tests/plugins/basic_auth_test.py b/tests/plugins/basic_auth_test.py
@@ -12,6 +12,10 @@ class TestBasicAuthDetector(object):
         [
             ('https://username:password@yelp.com', True,),
             ('http://localhost:5000/<%= @variable %>', False,),
+            ('"https://url:8000";@something else', False,),
+            ('\'https://url:8000\';@something else', False,),
+            ('https://url:8000 @something else', False,),
+            ('https://url:8000/ @something else', False,),
         ],
     )
     def test_analyze_string(self, payload, should_flag):

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,10 @@ class TestBasicAuthDetector(object):`
`12`	`12`	`[`
`13`	`13`	`('https://username:[email protected]', True,),`
`14`	`14`	`('http://localhost:5000/<%= @variable %>', False,),`
	`15`	`+ ('"https://url:8000";@something else', False,),`
	`16`	`+ ('\'https://url:8000\';@something else', False,),`
	`17`	`+ ('https://url:8000 @something else', False,),`
	`18`	`+ ('https://url:8000/ @something else', False,),`
`15`	`19`	`],`
`16`	`20`	`)`
`17`	`21`	`def test_analyze_string(self, payload, should_flag):`