Skip to content

Commit c17e729

Browse files
authored
bug KnpLabs#890 Fix broken roave/bc-check test (acrobat)
This PR was merged into the 2.x branch. Discussion ---------- Previously the bc-check was broken due to a changed tag format, which causes an incorrect version/tag to be guessed. This was fixed in 5.0 ``` Detected last minor version: 2.14.0 In Process.php line 256: The command "'git' 'rev-parse' '2.14.0'" failed. Exit Code: 128(Invalid exit argument) Output: ================ 2.14.0 Error Output: ================ fatal: ambiguous argument '2.14.0': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: ``` Commits ------- 88e7a23 Fix broken roave/bc-check test
2 parents bacb73d + 88e7a23 commit c17e729

File tree

2 files changed

+2
-51
lines changed

2 files changed

+2
-51
lines changed

.github/bc-test.sh

Lines changed: 0 additions & 49 deletions
This file was deleted.

.travis.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ php:
1818

1919
matrix:
2020
include:
21-
- php: 7.2
21+
- php: 7.4.7
2222
name: Backward compatibillity check
23-
env: DEPENDENCIES="roave/backward-compatibility-check" TEST_COMMAND="./.github/bc-test.sh"
23+
env: DEPENDENCIES="roave/backward-compatibility-check" TEST_COMMAND="vendor/bin/roave-backward-compatibility-check"
2424
- php: 7.1
2525
name: phpstan
2626
script:

0 commit comments

Comments
 (0)