Code review required comment removal

henrygab · henrygab · commit ac94a65c4edf · 2020-08-03T01:56:28.000-07:00
diff --git a/libraries/Servo/src/nrf52/Servo.cpp b/libraries/Servo/src/nrf52/Servo.cpp
@@ -129,7 +129,7 @@ void Servo::write(int value)
 
 void Servo::writeMicroseconds(int value)
 {
-  if (this->pwm) { // pwm is only set when this->servoIndex != INVALID_SERVO
+  if (this->pwm) {
 	  uint8_t pin = servos[this->servoIndex].Pin.nbr;
   	this->pwm->writePin(pin, value/DUTY_CYCLE_RESOLUTION);
   }
@@ -142,7 +142,7 @@ int Servo::read() // return the value as degrees
 
 int Servo::readMicroseconds()
 {	
-  if (this->pwm) { // pwm is only set when this->servoIndex != INVALID_SERVO
+  if (this->pwm) {
     uint8_t pin = servos[this->servoIndex].Pin.nbr;
     return this->pwm->readPin(pin)*DUTY_CYCLE_RESOLUTION;
   }

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ void Servo::write(int value)`
`129`	`129`
`130`	`130`	`void Servo::writeMicroseconds(int value)`
`131`	`131`	`{`
`132`		`- if (this->pwm) { // pwm is only set when this->servoIndex != INVALID_SERVO`
	`132`	`+ if (this->pwm) {`
`133`	`133`	`uint8_t pin = servos[this->servoIndex].Pin.nbr;`
`134`	`134`	`this->pwm->writePin(pin, value/DUTY_CYCLE_RESOLUTION);`
`135`	`135`	`}`
`@@ -142,7 +142,7 @@ int Servo::read() // return the value as degrees`
`142`	`142`
`143`	`143`	`int Servo::readMicroseconds()`
`144`	`144`	`{`
`145`		`- if (this->pwm) { // pwm is only set when this->servoIndex != INVALID_SERVO`
	`145`	`+ if (this->pwm) {`
`146`	`146`	`uint8_t pin = servos[this->servoIndex].Pin.nbr;`
`147`	`147`	`return this->pwm->readPin(pin)*DUTY_CYCLE_RESOLUTION;`
`148`	`148`	`}`