Skip to content

Commit 21872bc

Browse files
committed
[analyzer] Don't delete TaintConfig copy constructor
Summary: Explicitly deleting the copy constructor makes compiling the function `ento::registerGenericTaintChecker` difficult with some compilers. When we construct an `llvm::Optional<TaintConfig>`, the optional is constructed with a const TaintConfig reference which it then uses to invoke the deleted TaintConfig copy constructor. I've observered this failing with clang 3.8 on Ubuntu 16.04. Reviewers: compnerd, Szelethus, boga95, NoQ, alexshap Subscribers: xazax.hun, baloghadamsoftware, szepet, a.sidorin, mikhail.ramalho, donat.nagy, dkrupp, Charusso, llvm-commits, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D66192 llvm-svn: 368779
1 parent 5ee4d7a commit 21872bc

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,9 @@ class GenericTaintChecker
7171
std::vector<NameArgsPair> Sinks;
7272

7373
TaintConfiguration() = default;
74-
TaintConfiguration(const TaintConfiguration &) = delete;
74+
TaintConfiguration(const TaintConfiguration &) = default;
7575
TaintConfiguration(TaintConfiguration &&) = default;
76-
TaintConfiguration &operator=(const TaintConfiguration &) = delete;
76+
TaintConfiguration &operator=(const TaintConfiguration &) = default;
7777
TaintConfiguration &operator=(TaintConfiguration &&) = default;
7878
};
7979

0 commit comments

Comments
 (0)