Forward Euler method in Coconut #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berquist
added
the
Implementation
|
Could you write a more functional version of 2? |
|
I think I might be able to. I'll try when I have more time to do it. |
|
@berquist if you have some time, could you do a review of this PR? I'm trying to merge and close non-active PRs (i.e. where reviews have not been addressed in a while) |
berquist
approved these changes
Dec 29, 2021
berquist
force-pushed
the
forward_euler_coconut
branch
from
5a3dbd9 to
62d0ceb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, so the commits show two possible versions of the Forward Euler method in Coconut.
Before editing the md file, I want to have some feedback on that.
I'm not sure I can have something more functional style than that, but it could be.
If there's no way, which version do you prefer? V1 is more concise and efficient for checking, but might be more confusing to beginners. V2 could maybe be made a little bit more functional style, and doesn't need creating a list or an array.