Skip to content

Stack queue in cpp #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 12, 2022
Merged

Stack queue in cpp #936

merged 10 commits into from
Jan 12, 2022

Conversation

ishwar00
Copy link
Contributor

No description provided.

@ishwar00 ishwar00 marked this pull request as ready for review November 14, 2021 08:36
ShadowMitia
ShadowMitia requested changes Nov 14, 2021
View reviewed changes
Copy link
Contributor

@ShadowMitia ShadowMitia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good start, a few bugs to fix and a few things to iron out and you should be good.

ishwar00 and others added 4 commits November 14, 2021 15:21
@ishwar00 @ShadowMitia
Update contents/stacks_and_queues/code/c++/queue.cpp
2a89d60 
adding version T const& front() const

Co-authored-by: Dimitri Belopopsky <[email protected]>
@ishwar00 @ShadowMitia
Update contents/stacks_and_queues/code/c++/queue.cpp
1bfc0c4 
removing unnecessary comment

Co-authored-by: Dimitri Belopopsky <[email protected]>
@ishwar00
improved implementation
9d9a245
@ishwar00
fixed queue implementation
7af16dd
henrikac
henrikac reviewed Nov 15, 2021
View reviewed changes
@Amaras Amaras added Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) lang: c++ C++ programming language labels Nov 22, 2021
@Amaras Amaras requested a review from ShadowMitia January 11, 2022 22:21
ShadowMitia
ShadowMitia approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@ShadowMitia ShadowMitia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@ShadowMitia ShadowMitia merged commit 28287e3 into algorithm-archivists:main Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrikac henrikac henrikac left review comments

@ShadowMitia ShadowMitia ShadowMitia approved these changes

Assignees
No one assigned
Labels
Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) lang: c++ C++ programming language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ishwar00 @ShadowMitia @henrikac @Amaras