Use "{:?}" format specifier for Show

See rust-lang/rust#20013

Author: alkor

examples/client.rs

@@ -14,7 +14,7 @@ use std::io::println;
 use url::Url;
 
 fn main() {
-    format!("{}", Get);
+    format!("{:?}", Get);
     let args = os::args();
     match args.len() {
         0 => unreachable!(),
@@ -34,8 +34,8 @@ fn make_and_print_request(url: &str) {
     println!("=======");
     println!("");
     println!("URL: {}", request.url);
-    println!("[1mRemote address:[0m {}", request.remote_addr);
-    println!("[1mMethod:[0m {}", request.method);
+    println!("[1mRemote address:[0m {:?}", request.remote_addr);
+    println!("[1mMethod:[0m {:?}", request.method);
     println!("Headers:");
     for header in request.headers.iter() {
         println!(" - {}: {}", header.header_name(), header.header_value());
@@ -49,7 +49,7 @@ fn make_and_print_request(url: &str) {
         Ok(response) => response,
         Err(_request) => panic!("This example can progress no further with no response :-("),
     };
-    println!("[1mStatus:[0m {}", response.status);
+    println!("[1mStatus:[0m {:?}", response.status);
     println!("Headers:");
     for header in response.headers.iter() {
         println!(" - {}: {}", header.header_name(), header.header_value());

examples/info.rs

@@ -33,10 +33,10 @@ impl Server for InfoServer {
 
         w.write(b"<h1>Request</h1>").unwrap();
         let s = format!("<dl>
-            <dt>Method</dt><dd>{}</dd>
-            <dt>Host</dt><dd>{}</dd>
-            <dt>Request URI</dt><dd>{}</dd>
-            <dt>HTTP version</dt><dd>{}</dd>
+            <dt>Method</dt><dd>{:?}</dd>
+            <dt>Host</dt><dd>{:?}</dd>
+            <dt>Request URI</dt><dd>{:?}</dd>
+            <dt>HTTP version</dt><dd>{:?}</dd>
             <dt>Close connection</dt><dd>{}</dd></dl>",
             r.method,
             r.headers.host,
@@ -58,7 +58,7 @@ impl Server for InfoServer {
         w.write(b"</pre>").unwrap();
 
         w.write(b"<h1>Response</h1>").unwrap();
-        let s = format!("<dl><dt>Status</dt><dd>{}</dd></dl>", w.status);
+        let s = format!("<dl><dt>Status</dt><dd>{:?}</dd></dl>", w.status);
         w.write(s.as_bytes()).unwrap();
         w.write(b"<h2>Headers</h2>").unwrap();
         w.write(b"<table><thead><tr><th>Name</th><th>Value</th></thead><tbody>").unwrap();

src/http/client/request.rs

@@ -237,7 +237,7 @@ impl<S: Connecter + Reader + Writer = super::NetworkStream> RequestWriter<S> {
             None => ("", "")
         };
         try!(write!(self.stream.as_mut().unwrap() as &mut Writer,
-            "{} {}{}{} HTTP/1.0\r\n",
+            "{:?} {}{}{} HTTP/1.0\r\n",
             self.method, self.url.serialize_path().unwrap(), question_mark, query));
 
         try!(self.headers.write_all(self.stream.as_mut().unwrap()));

src/http/client/sslclients/openssl.rs

@@ -72,7 +72,7 @@ fn lift_ssl_error(ssl: SslError) -> IoError {
         OpenSslErrors(errs) => IoError {
             kind: OtherIoError,
             desc: "Error in OpenSSL",
-            detail: Some(format!("{}", errs))
+            detail: Some(format!("{:?}", errs))
         }
     }
 }

src/http/headers/content_type.rs

@@ -71,7 +71,7 @@ impl super::HeaderConvertible for MediaType {
     }
 
     fn http_value(&self) -> String {
-        format!("{}", self)
+        format!("{:?}", self)
     }
 }
 

src/http/headers/etag.rs

@@ -66,7 +66,7 @@ impl super::HeaderConvertible for EntityTag {
     }
 
     fn http_value(&self) -> String {
-        format!("{}", self)
+        format!("{:?}", self)
     }
 }
 

src/http/headers/host.rs

@@ -41,6 +41,6 @@ impl super::HeaderConvertible for Host {
     }
 
     fn http_value(&self) -> String {
-        format!("{}", self)
+        format!("{:?}", self)
     }
 }

src/http/headers/mod.rs

@@ -666,7 +666,7 @@ impl HeaderConvertible for Method {
     }
 
     fn http_value(&self) -> String {
-        format!("{}", self)
+        format!("{:?}", self)
     }
 }
 

src/http/server/response.rs

@@ -72,7 +72,7 @@ impl<'a> ResponseWriter<'a> {
         // XXX: might be better not to hardcode HTTP/1.1.
         // XXX: Rust's current lack of statement-duration lifetime handling prevents this from being
         // one statement ("error: borrowed value does not live long enough")
-        let s = format!("HTTP/1.1 {}\r\n", self.status);
+        let s = format!("HTTP/1.1 {:?}\r\n", self.status);
         try!(self.writer.write(s.as_bytes()));
 
         // FIXME: this is not an impressive way of handling it, but so long as chunked is the only