Merge pull request swiftlang#516 from kimdv/kimdv/cherry-pick-remove-computed-location

[5.9] Remove force unwrapping for source location

Author: ahoppen

Sources/SwiftFormatCore/Finding+Convenience.swift

@@ -14,18 +14,7 @@ import SwiftSyntax
 
 extension Finding.Location {
   /// Creates a new `Finding.Location` by converting the given `SourceLocation` from `SwiftSyntax`.
-  ///
-  /// If the source location is invalid (i.e., any of its fields are nil), then the initializer will
-  /// return nil.
-  public init?(_ sourceLocation: SourceLocation) {
-    guard
-      let file = sourceLocation.file,
-      let line = sourceLocation.line,
-      let column = sourceLocation.column
-    else {
-      return nil
-    }
-
-    self.init(file: file, line: line, column: column)
+  public init(_ sourceLocation: SourceLocation) {
+    self.init(file: sourceLocation.file, line: sourceLocation.line, column: sourceLocation.column)
   }
 }

Sources/swift-format/Utilities/UnifiedDiagnosticsEngine.swift

@@ -55,9 +55,7 @@ final class UnifiedDiagnosticsEngine {
     var description: String {
       switch self {
       case .parserLocation(let location):
-        // SwiftSyntax's old diagnostic printer also force-unwrapped these, so we assume that they
-        // will always be present if the location itself is non-nil.
-        return "\(location.file!):\(location.line!):\(location.column!)"
+        return "\(location.file):\(location.line):\(location.column)"
       case .findingLocation(let location):
         return "\(location.file):\(location.line):\(location.column)"
       }