Skip to content

Commit 441b8e4

Browse files
author
shiro
authored
feat(settings.py): Now compares all settings (#41)
1 parent 4af6c09 commit 441b8e4

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

repo_manager/github/settings.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,15 +65,20 @@ def get_repo_value(setting_name: str, repo: Repository) -> Any | None:
6565
checked = True
6666
for setting_name in settings.dict().keys():
6767
repo_value = get_repo_value(setting_name, repo)
68-
if repo_value is None:
69-
continue
7068
settings_value = getattr(settings, setting_name)
69+
# These don't seem to update if changed; may need to explore a different API call
70+
if ((setting_name == "enable_automated_security_fixes") | (setting_name == "enable_vulnerability_alerts")):
71+
continue
72+
# We don't want to flag description being different if the YAML is None
73+
if (setting_name == "description") & (not settings_value):
74+
continue
75+
elif (setting_name == "topics") & (settings_value is None):
76+
settings_value = []
7177
if repo_value != settings_value:
7278
drift.append(f"{setting_name} -- Expected: '{settings_value}' Found: '{repo_value}'")
73-
checked = False
79+
checked &= False if (settings_value is not None) else True
7480
return checked, drift
7581

76-
7782
def update(repo: Repository, setting_name: str, new_value: Any):
7883
"""[summary]
7984

0 commit comments

Comments
 (0)