Skip to content

Commit e5368b8

Browse files
committed
refactor(@ngtools/webpack): add types to exported module variables
Adding explicit type information for a module's exported variables allows the `@ngtools/webpack` package to be built with the `isolatedDeclarations` option.
1 parent 23ebfd9 commit e5368b8

File tree

5 files changed

+8
-6
lines changed

5 files changed

+8
-6
lines changed

packages/ngtools/webpack/src/ivy/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@
99
export { angularWebpackLoader as default } from './loader';
1010
export { type AngularWebpackPluginOptions, AngularWebpackPlugin, imageDomains } from './plugin';
1111

12-
export const AngularWebpackLoaderPath = __filename;
12+
export const AngularWebpackLoaderPath: string = __filename;

packages/ngtools/webpack/src/ivy/paths.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ function externalizeForWindows(path: string): string {
3434
return result;
3535
}
3636

37-
export const externalizePath = (() => {
37+
export const externalizePath: typeof externalizeForWindows = (() => {
3838
if (process.platform !== 'win32') {
3939
return (path: string) => path;
4040
}

packages/ngtools/webpack/src/ivy/plugin.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ import { createAotTransformers, createJitTransformers, mergeTransformers } from
3939
*/
4040
const DIAGNOSTICS_AFFECTED_THRESHOLD = 1;
4141

42-
export const imageDomains = new Set<string>();
42+
export const imageDomains: Set<string> = new Set();
4343

4444
export interface AngularWebpackPluginOptions {
4545
tsconfig: string;

packages/ngtools/webpack/src/ivy/symbol.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* found in the LICENSE file at https://angular.dev/license
77
*/
88

9-
export const AngularPluginSymbol = Symbol.for('@ngtools/webpack[angular-compiler]');
9+
export const AngularPluginSymbol: unique symbol = Symbol.for('@ngtools/webpack[angular-compiler]');
1010

1111
export interface EmitFileResult {
1212
content?: string;

packages/ngtools/webpack/src/loaders/inline-resource.ts

+4-2
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,11 @@
88

99
import type { Compilation, LoaderContext } from 'webpack';
1010

11-
export const InlineAngularResourceLoaderPath = __filename;
11+
export const InlineAngularResourceLoaderPath: string = __filename;
1212

13-
export const InlineAngularResourceSymbol = Symbol('@ngtools/webpack[angular-resource]');
13+
export const InlineAngularResourceSymbol: unique symbol = Symbol(
14+
'@ngtools/webpack[angular-resource]',
15+
);
1416

1517
export interface CompilationWithInlineAngularResource extends Compilation {
1618
[InlineAngularResourceSymbol]: string;

0 commit comments

Comments
 (0)