fix(@angular/cli): fixes Yarn v2 support for registry configuration #26860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for yarnrc.yml files so that users of Yarn v2+ who attempt to run `ng add` or `ng update` do not experience a bug where the incorrect registry file extension (.yarnrc) is selected. Fixes angular#23448
|
Hey @petomi, thanks for the PR. However, it seems it's not sufficient to support Yarn 2.0, as discussed in #23448 (comment). The option names in |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
yarnrc.ymlfiles so that users of Yarn v2+ who attempt to runng addorng updatedo not experience a bug where the incorrect registry file extension (.yarnrc) is selected.Fixes #23448
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently repositories using Yarn v2 or higher do not use the correct registry configuration file format, which causes issues when running ng-cli commands that require access to private repositories. See:
#23448
Issue Number: 23448
What is the new behavior?
The
ng addandng updatecommands check the correct file format (yarnrc.yml) for any repositories using Yarn version 2 or higher.Does this PR introduce a breaking change?
Other information