fix tests in ie9, introduce custom matcher

IE9 will report option.hasAttribute('selected') === true
if the option property has been unset and even if the
dev tools show that the attribute is not set.

I've added a custom matcher that accounts for this behavior. In all other browsers, property and attribute should always be
in the same state.

Author: Narretz

test/ng/directive/ngOptionsSpec.js

@@ -120,6 +120,40 @@ describe('ngOptions', function() {
             return { pass: errors.length === 0, message: message };
           }
         };
+      },
+      toBeMarkedAsSelected: function() {
+        // Selected is special because the element property and attribute reflect each other's state.
+        // IE9 will wrongly report hasAttribute('selected') === true when the property is
+        // undefined or null, and the dev tools show that no attribute is set
+        return {
+          compare: function(actual) {
+            var errors = [];
+            if (actual.selected === null || typeof actual.selected === 'undefined' || actual.selected === false) {
+              errors.push('Expected option property "selected" to be truthy');
+            }
+
+            if (msie !== 9 && actual.hasAttribute('selected') === false) {
+              errors.push('Expected option to have attribute "selected"');
+            }
+
+            var message = function() {
+              return errors.join('\n');
+            };
+
+            var result = {};
+
+            result.pass = errors.length === 0;
+
+            if (result.pass) {
+              result.message = 'Expected option property "selected" to be falsy' +
+                (msie !== 9 ? ' and option not to have attribute "selected"' : '');
+            } else {
+              result.message = message;
+            }
+
+            return result;
+          }
+        };
       }
     });
   });
@@ -753,31 +787,31 @@ describe('ngOptions', function() {
     }, true);
 
     var options = element.find('option');
-    expect(options[0].getAttribute('selected')).toBe('selected');
-    expect(options[1].hasAttribute('selected')).toBe(false);
-    expect(options[2].hasAttribute('selected')).toBe(false);
+    expect(options[0]).toBeMarkedAsSelected();
+    expect(options[1]).not.toBeMarkedAsSelected();
+    expect(options[2]).not.toBeMarkedAsSelected();
 
     scope.selected = scope.values[0];
     scope.$digest();
 
-    expect(options[0].hasAttribute('selected')).toBe(false);
-    expect(options[1].getAttribute('selected')).toBe('selected');
-    expect(options[2].hasAttribute('selected')).toBe(false);
+    expect(options[0]).not.toBeMarkedAsSelected();
+    expect(options[1]).toBeMarkedAsSelected();
+    expect(options[2]).not.toBeMarkedAsSelected();
 
     scope.selected = scope.values[1];
     scope.$digest();
 
-    expect(options[0].hasAttribute('selected')).toBe(false);
-    expect(options[1].hasAttribute('selected')).toBe(false);
-    expect(options[2].getAttribute('selected')).toBe('selected');
+    expect(options[0]).not.toBeMarkedAsSelected();
+    expect(options[1]).not.toBeMarkedAsSelected();
+    expect(options[2]).toBeMarkedAsSelected();
 
     scope.selected = 'no match';
     scope.$digest();
 
     expect(options[0].selected).toBe(true);
-    expect(options[0].getAttribute('selected')).toBe('selected');
-    expect(options[1].hasAttribute('selected')).toBe(false);
-    expect(options[2].hasAttribute('selected')).toBe(false);
+    expect(options[0]).toBeMarkedAsSelected();
+    expect(options[1]).not.toBeMarkedAsSelected();
+    expect(options[2]).not.toBeMarkedAsSelected();
   });
 
   describe('disableWhen expression', function() {
@@ -1446,10 +1480,9 @@ describe('ngOptions', function() {
       scope.selected = {};
       scope.$digest();
 
-      expect(options[0].selected).toBe(true);
-      expect(options[0].getAttribute('selected')).toBe('selected');
-      expect(options[2].selected).toBe(false);
-      expect(options[2].hasAttribute('selected')).toBe(false);
+      expect(options[0]).toBeMarkedAsSelected();
+      expect(options[2]).not.toBeMarkedAsSelected();
+      expect(options[2]).not.toBeMarkedAsSelected();
     });
 
   });