fix(youtube-player): YT.Player is not a constructor

Ronll · Ronll · commit 06c2784fcf96 · 2020-09-21T18:52:29.000+03:00
fixes a race condition where window.YT would be truthy but window.YT.Player would not be ready. Fixes #20598
diff --git a/src/youtube-player/youtube-player.ts b/src/youtube-player/youtube-player.ts
@@ -210,7 +210,7 @@ export class YouTubePlayer implements AfterViewInit, OnDestroy, OnInit {
     }
 
     let iframeApiAvailableObs: Observable<boolean> = observableOf(true);
-    if (!window.YT) {
+    if (!window.YT || !window.YT.Player) {
       if (this.showBeforeIframeApiLoads && (typeof ngDevMode === 'undefined' || ngDevMode)) {
         throw new Error('Namespace YT not found, cannot construct embedded youtube player. ' +
             'Please install the YouTube Player API Reference for iframe Embeds: ' +

Original file line number	Diff line number	Diff line change
`@@ -210,7 +210,7 @@ export class YouTubePlayer implements AfterViewInit, OnDestroy, OnInit {`
`210`	`210`	`}`
`211`	`211`
`212`	`212`	`let iframeApiAvailableObs: Observable<boolean> = observableOf(true);`
`213`		`- if (!window.YT) {`
	`213`	`+ if (!window.YT \|\| !window.YT.Player) {`
`214`	`214`	`if (this.showBeforeIframeApiLoads && (typeof ngDevMode === 'undefined' \|\| ngDevMode)) {`
`215`	`215`	`throw new Error('Namespace YT not found, cannot construct embedded youtube player. ' +`
`216`	`216`	`'Please install the YouTube Player API Reference for iframe Embeds: ' +`