Skip to content

Commit 1b2dc9c

Browse files
authored
build: update to latest version of rules_sass (#23491)
Updates to the latest version of `rules_sass` which provides the `npm_sass_library` rule allowing us to drop the code we currently have to maintain on our own.
1 parent 9aa21dc commit 1b2dc9c

File tree

9 files changed

+13
-67
lines changed

9 files changed

+13
-67
lines changed

WORKSPACE

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,10 @@ http_archive(
1515
# Add sass rules
1616
http_archive(
1717
name = "io_bazel_rules_sass",
18-
sha256 = "80d3e70ab5a8d59494aa9e3a7e4722f9f9a6fe98d1497be6bfa0b9e106b1ea54",
19-
strip_prefix = "rules_sass-1.34.1",
18+
sha256 = "60fa023fe694848acf769d816ad9fee970a27a37489aaf5443a7ccffaac805e9",
19+
strip_prefix = "rules_sass-1.38.2",
2020
urls = [
21-
"https://github.com/bazelbuild/rules_sass/archive/1.34.1.zip",
22-
"https://mirror.bazel.build/github.com/bazelbuild/rules_sass/archive/1.34.1.zip",
21+
"https://github.com/bazelbuild/rules_sass/archive/1.38.2.zip",
2322
],
2423
)
2524

src/dev-app/mdc-select/BUILD.bazel

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
load("@io_bazel_rules_sass//:defs.bzl", "sass_binary")
2-
load("//tools:defaults.bzl", "ng_module")
1+
load("//tools:defaults.bzl", "ng_module", "sass_binary")
32

43
package(default_visibility = ["//visibility:public"])
54

src/dev-app/mdc-sidenav/BUILD.bazel

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
load("@io_bazel_rules_sass//:defs.bzl", "sass_binary")
2-
load("//tools:defaults.bzl", "ng_module")
1+
load("//tools:defaults.bzl", "ng_module", "sass_binary")
32

43
package(default_visibility = ["//visibility:public"])
54

src/dev-app/mdc-snack-bar/BUILD.bazel

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
load("@io_bazel_rules_sass//:defs.bzl", "sass_binary")
2-
load("//tools:defaults.bzl", "ng_module")
1+
load("//tools:defaults.bzl", "ng_module", "sass_binary")
32

43
package(default_visibility = ["//visibility:public"])
54

src/dev-app/table-scroll-container/BUILD.bazel

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
load("@io_bazel_rules_sass//:defs.bzl", "sass_binary")
2-
load("//tools:defaults.bzl", "ng_module")
1+
load("//tools:defaults.bzl", "ng_module", "sass_binary")
32

43
package(default_visibility = ["//visibility:public"])
54

src/material-experimental/column-resize/BUILD.bazel

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
load("@io_bazel_rules_sass//:defs.bzl", "sass_library")
2-
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite")
1+
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite", "sass_library")
32

43
package(default_visibility = ["//visibility:public"])
54

src/material-experimental/mdc-helpers/BUILD.bazel

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
load("//tools:defaults.bzl", "sass_library")
2-
load("//tools:npm_sass_library.bzl", "npm_sass_library")
1+
load("//tools:defaults.bzl", "npm_sass_library", "sass_library")
32

43
package(default_visibility = ["//visibility:public"])
54

tools/defaults.bzl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Re-export of Bazel rules with repository-wide defaults
22

33
load("@build_bazel_rules_nodejs//:index.bzl", _pkg_npm = "pkg_npm")
4-
load("@io_bazel_rules_sass//:defs.bzl", _sass_binary = "sass_binary", _sass_library = "sass_library")
4+
load("@io_bazel_rules_sass//:defs.bzl", _npm_sass_library = "npm_sass_library", _sass_binary = "sass_binary", _sass_library = "sass_library")
55
load("@npm//@angular/bazel:index.bzl", _ng_module = "ng_module", _ng_package = "ng_package")
66
load("@npm//@bazel/jasmine:index.bzl", _jasmine_node_test = "jasmine_node_test")
77
load("@npm//@bazel/concatjs:index.bzl", _karma_web_test = "karma_web_test", _karma_web_test_suite = "karma_web_test_suite")
@@ -54,6 +54,9 @@ def sass_binary(sourcemap = False, **kwargs):
5454
def sass_library(**kwargs):
5555
_sass_library(**kwargs)
5656

57+
def npm_sass_library(**kwargs):
58+
_npm_sass_library(**kwargs)
59+
5760
def ts_library(tsconfig = None, deps = [], testonly = False, **kwargs):
5861
# Add tslib because we use import helpers for all public packages.
5962
local_deps = ["@npm//tslib"] + deps

tools/npm_sass_library.bzl

Lines changed: 0 additions & 50 deletions
This file was deleted.

0 commit comments

Comments
 (0)