fix(a11y): clear active item in key manager if it is removed from the list

The active item in the `ListKeyManager` gets updated on keyboard events, but if the list changes between them, we may end up in a state where it's pointing to an item that's not in the DOM anymore. This can cause something like `aria-activedescendant` to point to an invalid element.

These changes add some logic that clear the active element if it's removed from the list and there's nothing at its new index.

Author: crisbeto

src/cdk/a11y/key-manager/list-key-manager.spec.ts

@@ -105,6 +105,42 @@ describe('Key managers', () => {
       expect(keyManager.activeItem!.getLabel()).toBe('one');
     });
 
+    it('should update the active item if the current one is removed and there is ' +
+      'a new one at the same index', () => {
+        expect(keyManager.activeItemIndex).toBe(0);
+        expect(keyManager.activeItem!.getLabel()).toBe('one');
+
+        itemList.items = [new FakeFocusable('new-0'), new FakeFocusable('new-1')];
+        itemList.notifyOnChanges();
+
+        expect(keyManager.activeItemIndex).toBe(0);
+        expect(keyManager.activeItem!.getLabel()).toBe('new-0');
+      });
+
+    it('should clear the active item if nothing exists at the new index', () => {
+      keyManager.setActiveItem(2);
+
+      expect(keyManager.activeItemIndex).toBe(2);
+      expect(keyManager.activeItem!.getLabel()).toBe('three');
+
+      itemList.items = itemList.items.slice(0, 1);
+      itemList.notifyOnChanges();
+
+      expect(keyManager.activeItemIndex).toBe(-1);
+      expect(keyManager.activeItem).toBe(null);
+    });
+
+    it('should clear the active item if the list is cleared', () => {
+      expect(keyManager.activeItemIndex).toBe(0);
+      expect(keyManager.activeItem!.getLabel()).toBe('one');
+
+      itemList.items = [];
+      itemList.notifyOnChanges();
+
+      expect(keyManager.activeItemIndex).toBe(-1);
+      expect(keyManager.activeItem).toBe(null);
+    });
+
     it('should start off the activeItem as null', () => {
       expect(new ListKeyManager([]).activeItem).toBeNull();
     });

src/cdk/a11y/key-manager/list-key-manager.ts

@@ -70,7 +70,9 @@ export class ListKeyManager<T extends ListKeyManagerOption> {
           const itemArray = newItems.toArray();
           const newIndex = itemArray.indexOf(this._activeItem);
 
-          if (newIndex > -1 && newIndex !== this._activeItemIndex) {
+          if (newIndex === -1) {
+            this.updateActiveItem(this._activeItemIndex);
+          } else if (newIndex !== this._activeItemIndex) {
             this._activeItemIndex = newIndex;
           }
         }
@@ -347,7 +349,7 @@ export class ListKeyManager<T extends ListKeyManagerOption> {
 
     // Explicitly check for `null` and `undefined` because other falsy values are valid.
     this._activeItem = activeItem == null ? null : activeItem;
-    this._activeItemIndex = index;
+    this._activeItemIndex = activeItem == null ? -1 : index;
   }
 
   /**