Skip to content

Commit 2a401e8

Browse files
authored
refactor(material/snack-bar): refactor variable type to const in snack-bar component unit tests (#22774)
style(material/snack-bar): fix tslint trailing whitespace issue in ci build
1 parent 174303a commit 2a401e8

File tree

1 file changed

+31
-30
lines changed

1 file changed

+31
-30
lines changed

src/material/snack-bar/snack-bar.spec.ts

Lines changed: 31 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -185,10 +185,10 @@ describe('MatSnackBar', () => {
185185
});
186186

187187
it('should open and close a snackbar without a ViewContainerRef', fakeAsync(() => {
188-
let snackBarRef = snackBar.open('Snack time!', 'Chew');
188+
const snackBarRef = snackBar.open('Snack time!', 'Chew');
189189
viewContainerFixture.detectChanges();
190190

191-
let messageElement = overlayContainerElement.querySelector('snack-bar-container')!;
191+
const messageElement = overlayContainerElement.querySelector('snack-bar-container')!;
192192
expect(messageElement.textContent).toContain('Snack time!',
193193
'Expected snack bar to show a message without a ViewContainerRef');
194194

@@ -201,8 +201,8 @@ describe('MatSnackBar', () => {
201201
}));
202202

203203
it('should open a simple message with a button', () => {
204-
let config: MatSnackBarConfig = {viewContainerRef: testViewContainerRef};
205-
let snackBarRef = snackBar.open(simpleMessage, simpleActionLabel, config);
204+
const config: MatSnackBarConfig = {viewContainerRef: testViewContainerRef};
205+
const snackBarRef = snackBar.open(simpleMessage, simpleActionLabel, config);
206206

207207
viewContainerFixture.detectChanges();
208208

@@ -212,11 +212,11 @@ describe('MatSnackBar', () => {
212212
.toBe(snackBarRef,
213213
'Expected the snack bar reference to be placed in the component instance');
214214

215-
let messageElement = overlayContainerElement.querySelector('snack-bar-container')!;
215+
const messageElement = overlayContainerElement.querySelector('snack-bar-container')!;
216216
expect(messageElement.textContent)
217217
.toContain(simpleMessage, `Expected the snack bar message to be '${simpleMessage}'`);
218218

219-
let buttonElement = overlayContainerElement.querySelector('button.mat-button')!;
219+
const buttonElement = overlayContainerElement.querySelector('button.mat-button')!;
220220
expect(buttonElement.tagName)
221221
.toBe('BUTTON', 'Expected snack bar action label to be a <button>');
222222
expect(buttonElement.textContent)
@@ -225,8 +225,8 @@ describe('MatSnackBar', () => {
225225
});
226226

227227
it('should open a simple message with no button', () => {
228-
let config: MatSnackBarConfig = {viewContainerRef: testViewContainerRef};
229-
let snackBarRef = snackBar.open(simpleMessage, undefined, config);
228+
const config: MatSnackBarConfig = {viewContainerRef: testViewContainerRef};
229+
const snackBarRef = snackBar.open(simpleMessage, undefined, config);
230230

231231
viewContainerFixture.detectChanges();
232232

@@ -235,18 +235,18 @@ describe('MatSnackBar', () => {
235235
expect(snackBarRef.instance.snackBarRef)
236236
.toBe(snackBarRef, 'Expected the snack bar reference to be placed in the component instance');
237237

238-
let messageElement = overlayContainerElement.querySelector('snack-bar-container')!;
238+
const messageElement = overlayContainerElement.querySelector('snack-bar-container')!;
239239
expect(messageElement.textContent)
240240
.toContain(simpleMessage, `Expected the snack bar message to be '${simpleMessage}'`);
241241
expect(overlayContainerElement.querySelector('button.mat-button'))
242242
.toBeNull('Expected the query selection for action label to be null');
243243
});
244244

245245
it('should dismiss the snack bar and remove itself from the view', fakeAsync(() => {
246-
let config: MatSnackBarConfig = {viewContainerRef: testViewContainerRef};
247-
let dismissCompleteSpy = jasmine.createSpy('dismiss complete spy');
246+
const config: MatSnackBarConfig = {viewContainerRef: testViewContainerRef};
247+
const dismissCompleteSpy = jasmine.createSpy('dismiss complete spy');
248248

249-
let snackBarRef = snackBar.open(simpleMessage, undefined, config);
249+
const snackBarRef = snackBar.open(simpleMessage, undefined, config);
250250
viewContainerFixture.detectChanges();
251251
expect(overlayContainerElement.childElementCount)
252252
.toBeGreaterThan(0, 'Expected overlay container element to have at least one child');
@@ -322,8 +322,8 @@ describe('MatSnackBar', () => {
322322
}));
323323

324324
it('should set the animation state to visible on entry', () => {
325-
let config: MatSnackBarConfig = {viewContainerRef: testViewContainerRef};
326-
let snackBarRef = snackBar.open(simpleMessage, undefined, config);
325+
const config: MatSnackBarConfig = {viewContainerRef: testViewContainerRef};
326+
const snackBarRef = snackBar.open(simpleMessage, undefined, config);
327327

328328
viewContainerFixture.detectChanges();
329329
const container = snackBarRef.containerInstance as MatSnackBarContainer;
@@ -337,8 +337,8 @@ describe('MatSnackBar', () => {
337337
});
338338

339339
it('should set the animation state to complete on exit', () => {
340-
let config: MatSnackBarConfig = {viewContainerRef: testViewContainerRef};
341-
let snackBarRef = snackBar.open(simpleMessage, undefined, config);
340+
const config: MatSnackBarConfig = {viewContainerRef: testViewContainerRef};
341+
const snackBarRef = snackBar.open(simpleMessage, undefined, config);
342342
snackBarRef.dismiss();
343343

344344
viewContainerFixture.detectChanges();
@@ -349,17 +349,17 @@ describe('MatSnackBar', () => {
349349

350350
it(`should set the old snack bar animation state to complete and the new snack bar animation
351351
state to visible on entry of new snack bar`, fakeAsync(() => {
352-
let config: MatSnackBarConfig = {viewContainerRef: testViewContainerRef};
353-
let snackBarRef = snackBar.open(simpleMessage, undefined, config);
354-
let dismissCompleteSpy = jasmine.createSpy('dismiss complete spy');
352+
const config: MatSnackBarConfig = {viewContainerRef: testViewContainerRef};
353+
const snackBarRef = snackBar.open(simpleMessage, undefined, config);
354+
const dismissCompleteSpy = jasmine.createSpy('dismiss complete spy');
355355

356356
viewContainerFixture.detectChanges();
357357
const container1 = snackBarRef.containerInstance as MatSnackBarContainer;
358358
expect(container1._animationState)
359359
.toBe('visible', `Expected the animation state would be 'visible'.`);
360360

361-
let config2 = {viewContainerRef: testViewContainerRef};
362-
let snackBarRef2 = snackBar.open(simpleMessage, undefined, config2);
361+
const config2 = {viewContainerRef: testViewContainerRef};
362+
const snackBarRef2 = snackBar.open(simpleMessage, undefined, config2);
363363

364364
viewContainerFixture.detectChanges();
365365
snackBarRef.afterDismissed().subscribe({complete: dismissCompleteSpy});
@@ -374,7 +374,7 @@ describe('MatSnackBar', () => {
374374
}));
375375

376376
it('should open a new snackbar after dismissing a previous snackbar', fakeAsync(() => {
377-
let config: MatSnackBarConfig = {viewContainerRef: testViewContainerRef};
377+
const config: MatSnackBarConfig = {viewContainerRef: testViewContainerRef};
378378
let snackBarRef = snackBar.open(simpleMessage, 'Dismiss', config);
379379

380380
viewContainerFixture.detectChanges();
@@ -433,7 +433,7 @@ describe('MatSnackBar', () => {
433433
snackBarRef.afterDismissed().subscribe({complete: dismissCompleteSpy});
434434
snackBarRef.onAction().subscribe({complete: actionCompleteSpy});
435435

436-
let actionButton =
436+
const actionButton =
437437
overlayContainerElement.querySelector('button.mat-button') as HTMLButtonElement;
438438
actionButton.click();
439439
viewContainerFixture.detectChanges();
@@ -495,10 +495,10 @@ describe('MatSnackBar', () => {
495495
}));
496496

497497
it('should dismiss automatically after a specified timeout', fakeAsync(() => {
498-
let config = new MatSnackBarConfig();
498+
const config = new MatSnackBarConfig();
499499
config.duration = 250;
500-
let snackBarRef = snackBar.open('content', 'test', config);
501-
let afterDismissSpy = jasmine.createSpy('after dismiss spy');
500+
const snackBarRef = snackBar.open('content', 'test', config);
501+
const afterDismissSpy = jasmine.createSpy('after dismiss spy');
502502
snackBarRef.afterDismissed().subscribe(afterDismissSpy);
503503

504504
viewContainerFixture.detectChanges();
@@ -512,7 +512,7 @@ describe('MatSnackBar', () => {
512512
}));
513513

514514
it('should clear the dismiss timeout when dismissed before timeout expiration', fakeAsync(() => {
515-
let config = new MatSnackBarConfig();
515+
const config = new MatSnackBarConfig();
516516
config.duration = 1000;
517517
snackBar.open('content', 'test', config);
518518

@@ -526,7 +526,7 @@ describe('MatSnackBar', () => {
526526
}));
527527

528528
it('should clear the dismiss timeout when dismissed with action', fakeAsync(() => {
529-
let config = new MatSnackBarConfig();
529+
const config = new MatSnackBarConfig();
530530
config.duration = 1000;
531531
const snackBarRef = snackBar.open('content', 'test', config);
532532

@@ -543,7 +543,8 @@ describe('MatSnackBar', () => {
543543
snackBar.open(simpleMessage, simpleActionLabel, { panelClass: ['one', 'two'] });
544544
viewContainerFixture.detectChanges();
545545

546-
let containerClasses = overlayContainerElement.querySelector('snack-bar-container')!.classList;
546+
const containerClasses =
547+
overlayContainerElement.querySelector('snack-bar-container')!.classList;
547548

548549
expect(containerClasses).toContain('one');
549550
expect(containerClasses).toContain('two');
@@ -553,7 +554,7 @@ describe('MatSnackBar', () => {
553554
snackBar.open(simpleMessage, simpleActionLabel, { direction: 'rtl' });
554555
viewContainerFixture.detectChanges();
555556

556-
let pane = overlayContainerElement.querySelector('.cdk-global-overlay-wrapper')!;
557+
const pane = overlayContainerElement.querySelector('.cdk-global-overlay-wrapper')!;
557558

558559
expect(pane.getAttribute('dir')).toBe('rtl', 'Expected the pane to be in RTL mode.');
559560
});

0 commit comments

Comments
 (0)