Skip to content

Commit 33c1a6e

Browse files
committed
feat(google-maps/advanced-marker): remove default value for mapId and correct z-index description property for advanced markers
1 parent 66a6b17 commit 33c1a6e

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

src/google-maps/google-map/google-map.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ export const DEFAULT_OPTIONS: google.maps.MapOptions = {
4242
zoom: 17,
4343
// Note: the type conversion here isn't necessary for our CI, but it resolves a g3 failure.
4444
mapTypeId: 'roadmap' as unknown as google.maps.MapTypeId,
45-
mapId: '123',
4645
};
4746

4847
/** Arbitrary default height for the map element */
@@ -532,9 +531,6 @@ export class GoogleMap implements OnChanges, OnInit, OnDestroy {
532531
// Passing in an undefined `mapTypeId` seems to break tile loading
533532
// so make sure that we have some kind of default (see #22082).
534533
mapTypeId: this.mapTypeId || options.mapTypeId || DEFAULT_OPTIONS.mapTypeId,
535-
// Passing in an undefined `mapTypeId` seems to break tile loading
536-
// so make sure that we have some kind of default (see #22082).
537-
mapId: this.mapId || options.mapId || DEFAULT_OPTIONS.mapId,
538534
};
539535
}
540536

src/google-maps/map-advanced-marker/map-advanced-marker.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ export class MapAdvancedMarker implements OnInit, OnChanges, OnDestroy {
107107
private _options: google.maps.marker.AdvancedMarkerElementOptions;
108108

109109
/**
110-
* All AdvancedMarkerElements are displayed on the map in order of their zIndex, with higher values displaying in front of AdvancedMarkerElements with lower values. By default, AdvancedMarkerElements are displayed according to their vertical position on screen, with lower AdvancedMarkerElements appearing in front of AdvancedMarkerElements farther up the screen. Note that zIndex is also used to help determine relative priority between CollisionBehavior.OPTIONAL_AND_HIDES_LOWER_PRIORITY Advanced Markers. A higher zIndex value indicates higher priority.
110+
* AdvancedMarkerElements on the map are prioritized by zIndex, with higher values indicating higher display.
111111
* https://developers.google.com/maps/documentation/javascript/reference/advanced-markers#AdvancedMarkerElementOptions.zIndex
112112
*/
113113
@Input()

0 commit comments

Comments
 (0)